[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] [PATCH] Suppress warning 4715


  • To: Owen Smith <owen.smith@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Paul Durrant <Paul.Durrant@xxxxxxxxxx>
  • Date: Fri, 7 Jun 2019 09:51:35 +0000
  • Accept-language: en-GB, en-US
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=Paul.Durrant@xxxxxxxxxx; spf=SoftFail smtp.mailfrom=Paul.Durrant@xxxxxxxxxx; spf=None smtp.helo=postmaster@xxxxxxxxxxxxxxx
  • Cc: Owen Smith <owen.smith@xxxxxxxxxx>
  • Delivery-date: Fri, 07 Jun 2019 09:51:46 +0000
  • Ironport-sdr: 5EsVkjBxl7Mwu3uVBnyyo2ccayrKQQlnf0HgAQB1SWbiaB9uBCB9Fr9oIprKI7M4F076ACxTUp Uur1WrPmnFLjLhEITxRbTfmj0zqBDAfWRmqWGvVPOqEuDHJnilotDVVfK1phhu69QIApEkT+Pe ZI/i5bYYA8LfTQIG3A+njD4PYUb4OyoxoPbj7KJ66EXBArNc0/ged2+zdv/URdJlJEedup5WR2 yZpADCE4zSvuFT2cehwmW5jX+D0bmZhy+qjVRGh6eG6f1WyXheOpZ9VnI2ETKW3DjZ9e0MGdFD tWM=
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Thread-index: AQHVHQ0j0AXVhaQwLUiudtL2mp0HbaaP8vIA
  • Thread-topic: [win-pv-devel] [PATCH] Suppress warning 4715

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On 
> Behalf Of Owen Smith
> Sent: 07 June 2019 09:43
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Suppress warning 4715
> 
> __CacheMaskScan can trigger a compiler warning with some compilers due
> to not all return paths returning a value. The path that does not return
> a value calls KeBugCheckEx, which would leave unreachable code. Disable
> the specific warning for this function.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenbus/cache.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
> index 7daf8da..9713df3 100644
> --- a/src/xenbus/cache.c
> +++ b/src/xenbus/cache.c
> @@ -348,6 +348,7 @@ CacheDestroySlab(
>      MmFreeContiguousMemory(Slab);
>  }
> 
> +#pragma warning(disable: 4715)
>  static FORCEINLINE ULONG
>  __CacheMaskScan(
>      IN  ULONG   *Mask,
> @@ -374,6 +375,7 @@ __CacheMaskScan(
> 
>      BUG("CACHE SCAN FAILED");
>  }
> +#pragma warning(default: 4715)
> 
>  static FORCEINLINE VOID
>  __CacheMaskSet(
> --
> 2.16.2.windows.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.