Re: [win-pv-devel] [PATCH 14/14 v2] Fail FrontendPrepare if backend doesn't reinitialize

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of owen.smith@xxxxxxxxxx
> Sent: 23 February 2018 14:22
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 14/14 v2] Fail FrontendPrepare if backend
> doesn't reinitialize
> 
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> Current backend will crash (taking out the VM) if any attempt is
> made to reconnect to a backend that has transitioned to the
> Closed state. Forces the frontend offline, which will fail the
> frontend state transitions, and its initiating IRP.
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xencons/frontend.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/xencons/frontend.c b/src/xencons/frontend.c
> index f7d3b23..9f6e13d 100755
> --- a/src/xencons/frontend.c
> +++ b/src/xencons/frontend.c
> @@ -652,6 +652,12 @@ FrontendPrepare(
>          case XenbusStateClosed:
>              FrontendSetXenbusState(Frontend,
>                                     XenbusStateClosed);
> +            // There is currently a bug in the backend.
> +            // Once the backend reaches Closed, it will crash the
> +            // frontend attempts to make any state transition.
> +            // Avoid the bug by forcing the frontend offline and
> +            // failing FrontendPrepare
> +            FrontendSetOffline(Frontend);
>              break;
>          default:
>              FrontendSetXenbusState(Frontend,
> --
> 2.8.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/win-pv-devel