Re: [win-pv-devel] [PATCH 0/5] Ongoing Improvements

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of Paul Durrant
> Sent: 29 September 2017 17:55
> To: Owen Smith <owen.smith@xxxxxxxxxx>; win-pv-
> devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: Re: [win-pv-devel] [PATCH 0/5] Ongoing Improvements
> 
> > -----Original Message-----
> > From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx]
> On
> > Behalf Of owen.smith@xxxxxxxxxx
> > Sent: 26 September 2017 14:50
> > To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> > Subject: [win-pv-devel] [PATCH 0/5] Ongoing Improvements
> >
> > From: Owen Smith <owen.smith@xxxxxxxxxx>
> >
> > This series changes the behaviour of XenVbd to improve the
> > overall design and implementation.
> > * Use the CACHE interface for bounce buffers, which removes a
> >   log entry which can be triggered every 1 second if the user
> >   buffers for IO are not aligned to sector sizes.
> > * Adds a useful override on max-ring-page-order. blkback will
> >   define max-ring-page-order to use 16 pages for a ring, which can be
> >   excessive for most use cases. The xenvbd frontend will use the
> >   maximum number of pages possible for the ring.
> > * Use the CACHE interface instead of lookaside lists for the
> >   REQUEST, SEGMENT and INDIRECT structs. This allows one time
> >   initialization/cleanup, which will prevent xenvbd allocating
> >   a page every time it retrieves a cached INDIRECT.
> >
> > Owen Smith (5):
> >   Query for CACHE interface
> >   Use CACHE interface for bounce buffers
> >   Add override for MaxRingPageOrder
> >   Tidy up srbext.h
> >   Use CACHE interface for REQUESTs, SEGMENTs and INDIRECTs
> 
> I was just doing sanity tests of these prior to push and I got a BSOD on
> shutdown with an RS2 VM. Looked to be tearing down the grant table. How
> much testing has this code had? You need to verify suspend/resume too.
> 

The bug was in previously committed code. I've just sent a patch to fix this.

  Paul

>   Paul
> 
> >
> >  src/xenvbd/adapter.c         | 174 ++++++++-
> >  src/xenvbd/adapter.h         |  13 +
> >  src/xenvbd/buffer.c          | 426 ---------------------
> >  src/xenvbd/buffer.h          |  80 ----
> >  src/xenvbd/driver.c          |   9 +-
> >  src/xenvbd/driver.h          |   1 +
> >  src/xenvbd/ring.c            | 881 +++++++++++++++++++++++++---------------
> --
> > -
> >  src/xenvbd/srbext.h          | 109 ++----
> >  src/xenvbd/target.c          |   7 +-
> >  vs2015/xenvbd/xenvbd.vcxproj |   1 -
> >  10 files changed, 733 insertions(+), 968 deletions(-)
> >  delete mode 100644 src/xenvbd/buffer.c
> >  delete mode 100644 src/xenvbd/buffer.h
> >
> > --
> > 2.8.3
> >
> >
> > _______________________________________________
> > win-pv-devel mailing list
> > win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel