Re: [win-pv-devel] [PATCH 0/7] Refactoring

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of owen.smith@xxxxxxxxxx
> Sent: 20 September 2017 16:53
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH 0/7] Refactoring
> 
> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> This series attempts to relocate code to the corrct source file
> * target.c should contain SRB handling for requests that are not
>   passed to the backend.
> * frontend.c should contain the state model and non-block protocol
>   access to xenstore.
> * ring.c should contain all SRB handling and the block protocol
>   implementation.
> Each source file should contain its own debug callback handler
> 
> Owen Smith (7):
>   Merge Notifier and BlockRing into Ring
>   Use macros for Frontend data accessors
>   Move request prepare/cleanup to ring
>   Tidy up FrontendDebugCallback
>   Tidy up GranterDebugCallback
>   Move Inquiry handling into target.c
>   Remove generic store accessors in frontend

All:

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> 
>  src/xenvbd/base64.c          |  174 ++++
>  src/xenvbd/base64.h          |   50 +
>  src/xenvbd/blockring.c       |  597 ------------
>  src/xenvbd/blockring.h       |   97 --
>  src/xenvbd/frontend.c        |  818 ++++++++--------
>  src/xenvbd/frontend.h        |  136 ++-
>  src/xenvbd/granter.c         |  146 ++-
>  src/xenvbd/granter.h         |   46 +-
>  src/xenvbd/notifier.c        |  390 --------
>  src/xenvbd/notifier.h        |  101 --
>  src/xenvbd/pdoinquiry.c      |  530 -----------
>  src/xenvbd/pdoinquiry.h      |   64 --
>  src/xenvbd/ring.c            | 2133
> ++++++++++++++++++++++++++++++++++++++++++
>  src/xenvbd/ring.h            |   99 ++
>  src/xenvbd/target.c          | 1651 ++++++--------------------------
>  src/xenvbd/target.h          |   12 -
>  vs2015/xenvbd/xenvbd.vcxproj |    5 +-
>  17 files changed, 3322 insertions(+), 3727 deletions(-)
>  create mode 100755 src/xenvbd/base64.c
>  create mode 100755 src/xenvbd/base64.h
>  delete mode 100644 src/xenvbd/blockring.c
>  delete mode 100644 src/xenvbd/blockring.h
>  delete mode 100644 src/xenvbd/notifier.c
>  delete mode 100644 src/xenvbd/notifier.h
>  delete mode 100644 src/xenvbd/pdoinquiry.c
>  delete mode 100644 src/xenvbd/pdoinquiry.h
>  create mode 100755 src/xenvbd/ring.c
>  create mode 100755 src/xenvbd/ring.h
> 
> --
> 2.8.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel