Re: [win-pv-devel] [PATCH] Dont disconnect/connect ring when target is Reset.

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel [mailto:win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx] On
> Behalf Of owen.smith@xxxxxxxxxx
> Sent: 09 December 2016 10:06
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith <owen.smith@xxxxxxxxxx>
> Subject: [win-pv-devel] [PATCH] Dont disconnect/connect ring when target
> is Reset.
> 

Yes, this is pointless and dangerous (as blkback lacks proper synchronization 
between shared ring state changes and in-flight requests).

> From: Owen Smith <owen.smith@xxxxxxxxxx>
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

> ---
>  src/xenvbd/pdo.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/src/xenvbd/pdo.c b/src/xenvbd/pdo.c
> index 3efe711..8bd9a10 100644
> --- a/src/xenvbd/pdo.c
> +++ b/src/xenvbd/pdo.c
> @@ -2232,8 +2232,6 @@ PdoReset(
>      __in PXENVBD_PDO             Pdo
>      )
>  {
> -    NTSTATUS        Status;
> -
>      Trace("Target[%d] ====> (Irql=%d)\n", PdoGetTargetId(Pdo),
> KeGetCurrentIrql());
> 
>      __PdoPauseDataPath(Pdo, TRUE);
> @@ -2243,17 +2241,6 @@ PdoReset(
>                  PdoGetTargetId(Pdo), QueueCount(&Pdo->SubmittedReqs));
>      }
> 
> -    Status = FrontendSetState(Pdo->Frontend, XENVBD_CLOSING);
> -    ASSERT(NT_SUCCESS(Status));
> -
> -    __PdoCleanupSubmittedReqs(Pdo);
> -
> -    Status = FrontendSetState(Pdo->Frontend, XENVBD_CLOSED);
> -    ASSERT(NT_SUCCESS(Status));
> -
> -    Status = FrontendSetState(Pdo->Frontend, XENVBD_ENABLED);
> -    ASSERT(NT_SUCCESS(Status));
> -
>      __PdoUnpauseDataPath(Pdo);
> 
>      Trace("Target[%d] <==== (Irql=%d)\n", PdoGetTargetId(Pdo),
> KeGetCurrentIrql());
> --
> 2.8.3
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel
_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel