[win-pv-devel] [PATCH] Add more diagnostic messages

[Paul Durrant <paul.durrant@xxxxxxxxxx>]

Log a message at start and end of both transmitter and receiver
ring enable and disable functions. Testing has thrown up some hangs
that appear to be in one of these functions.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenvif/receiver.c    | 22 ++++++++++++++++++++++
 src/xenvif/transmitter.c | 16 ++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c
index 8562259..f54d368 100644
--- a/src/xenvif/receiver.c
+++ b/src/xenvif/receiver.c
@@ -2735,6 +2735,10 @@ __ReceiverRingEnable(
     Receiver = Ring->Receiver;
     Frontend = Receiver->Frontend;
 
+    Info("%s[%u]: ====>\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     __ReceiverRingAcquireLock(Ring);
 
     ASSERT(!Ring->Enabled);
@@ -2751,6 +2755,10 @@ __ReceiverRingEnable(
 
     __ReceiverRingReleaseLock(Ring);
 
+    Info("%s[%u]: <====\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     return STATUS_SUCCESS;
 
 fail1:
@@ -2766,6 +2774,16 @@ __ReceiverRingDisable(
     IN  PXENVIF_RECEIVER_RING   Ring
     )
 {    
+    PXENVIF_RECEIVER            Receiver;
+    PXENVIF_FRONTEND            Frontend;
+
+    Receiver = Ring->Receiver;
+    Frontend = Receiver->Frontend;
+
+    Info("%s[%u]: ====>\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     __ReceiverRingAcquireLock(Ring);
 
     ASSERT(Ring->Enabled);
@@ -2780,6 +2798,10 @@ __ReceiverRingDisable(
     // Cancel any existing ones.
     //
     (VOID) KeCancelTimer(&Ring->Timer);
+
+    Info("%s[%u]: <====\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
 }
 
 static FORCEINLINE VOID
diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index 9a6fbd1..175ea03 100644
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -3926,6 +3926,10 @@ __TransmitterRingEnable(
     Transmitter = Ring->Transmitter;
     Frontend = Transmitter->Frontend;
 
+    Info("%s[%u]: ====>\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     __TransmitterRingAcquireLock(Ring);
 
     ASSERT(!Ring->Enabled);
@@ -3935,6 +3939,10 @@ __TransmitterRingEnable(
 
     __TransmitterRingReleaseLock(Ring);
 
+    Info("%s[%u]: <====\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     return STATUS_SUCCESS;
 }
 
@@ -3954,6 +3962,10 @@ __TransmitterRingDisable(
     Transmitter = Ring->Transmitter;
     Frontend = Transmitter->Frontend;
 
+    Info("%s[%u]: ====>\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
+
     __TransmitterRingAcquireLock(Ring);
 
     ASSERT(Ring->Enabled);
@@ -4027,6 +4039,10 @@ __TransmitterRingDisable(
     // Cancel any existing ones.
     //
     (VOID) KeCancelTimer(&Ring->Timer);
+
+    Info("%s[%u]: <====\n",
+         FrontendGetPath(Frontend),
+         Ring->Index);
 }
 
 static FORCEINLINE VOID
-- 
2.5.3


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel