[win-pv-devel] [PATCH] Get rid of the MonitorEvent from CACHE context

[Paul Durrant <pdurrant@xxxxxxxxx>]

The event is being signalled but nothing ever takes notice of it so one
can only conclude that it is not needed.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenbus/cache.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/src/xenbus/cache.c b/src/xenbus/cache.c
index 9058d56..e2c83a8 100644
--- a/src/xenbus/cache.c
+++ b/src/xenbus/cache.c
@@ -92,7 +92,6 @@ struct _XENBUS_CACHE_CONTEXT {
     PXENBUS_DEBUG_CALLBACK  DebugCallback;
     XENBUS_STORE_INTERFACE  StoreInterface;
     PXENBUS_THREAD          MonitorThread;
-    KEVENT                  MonitorEvent;
     LIST_ENTRY              List;
 };
 
@@ -787,8 +786,6 @@ CacheMonitor(
 
 loop:
         KeReleaseSpinLock(&Context->Lock, Irql);
-
-        KeSetEvent(&Context->MonitorEvent, IO_NO_INCREMENT, FALSE);
     }
 
     Trace("====>\n");
@@ -921,8 +918,6 @@ CacheInitialize(
     InitializeListHead(&(*Context)->List);
     KeInitializeSpinLock(&(*Context)->Lock);
 
-    KeInitializeEvent(&(*Context)->MonitorEvent, NotificationEvent, FALSE);
-
     status = ThreadCreate(CacheMonitor, *Context, &(*Context)->MonitorThread);
     if (!NT_SUCCESS(status))
         goto fail2;
@@ -936,8 +931,6 @@ CacheInitialize(
 fail2:
     Error("fail2\n");
 
-    RtlZeroMemory(&(*Context)->MonitorEvent, sizeof (KEVENT));
-
     RtlZeroMemory(&(*Context)->Lock, sizeof (KSPIN_LOCK));
     RtlZeroMemory(&(*Context)->List, sizeof (LIST_ENTRY));
 
@@ -1004,8 +997,6 @@ CacheTeardown(
     ThreadJoin(Context->MonitorThread);
     Context->MonitorThread = NULL;
 
-    RtlZeroMemory(&Context->MonitorEvent, sizeof (KEVENT));
-
     RtlZeroMemory(&Context->Lock, sizeof (KSPIN_LOCK));
     RtlZeroMemory(&Context->List, sizeof (LIST_ENTRY));
 
-- 
2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel