[win-pv-devel] [PATCH 1/3] Fix NDISTest PacketFilters test

[Paul Durrant <pdurrant@xxxxxxxxx>]

The PacketFilters test fails because it has apparently discovered a whole
load of invalid filters. This, as it turns out, is not because of any bug
in the query OID code but rather in the set OID code. The code as it stands
returns success even for setting an invalid filter, and this is why the
test believes those filters are enabled.
This patch stops ignoring the resturn code of AdapterSetPacketFilter and
hence fixes the test.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xennet/adapter.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/xennet/adapter.c b/src/xennet/adapter.c
index 8616579..f96386c 100644
--- a/src/xennet/adapter.c
+++ b/src/xennet/adapter.c
@@ -1093,8 +1093,8 @@ AdapterSetInformation(
     case OID_GEN_CURRENT_PACKET_FILTER:
         BytesNeeded = sizeof(ULONG);
         if (BufferLength == BytesNeeded) {
-            AdapterSetPacketFilter(Adapter,
-                                   (PULONG)Buffer);
+            ndisStatus = AdapterSetPacketFilter(Adapter,
+                                                (PULONG)Buffer);
             BytesRead = sizeof(ULONG);
         }
         break;
-- 
2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel