Re: odd build error

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

Remove the square brackets around the type, as those are only for polymorphic 
variants. Or add a backtick to the ADD, REMOVE to make them polymorphic.

Anil 



On 12 Aug 2011, at 09:12, Richard Mortier <Richard.Mortier@xxxxxxxxxxxxxxxx> 
wrote:

> i'm making a start at an openflow implementation in mirage.  just starting to 
> get dave's packet parsing mpl ported over to bitstring.  am hitting a compile 
> error that i don't understand:
> 
> /usr/local/bin/ocamldep.opt -pp 'camlp4o -I ../../../syntax/_build pa_lwt.cma 
> pa_bitstring.cma pa_js.cma' -modules openflow/ofpacket.ml > 
> openflow/ofpacket.ml.depends
> + /usr/local/bin/ocamldep.opt -pp 'camlp4o -I ../../../syntax/_build 
> pa_lwt.cma pa_bitstring.cma pa_js.cma' -modules openflow/ofpacket.ml > 
> openflow/ofpacket.ml.depends
> File "ghost-location", line 448, characters 40--13388 (end at line 1, 
> character 0):
> Failure: "invalid long identifier type"
> Preprocessing error on file openflow/ofpacket.ml
> Command exited with code 2.
> make[1]: *** [node-socket-node] Error 10
> 
> all checked in on openflow branch; code around that line is:
> 
> """
> type phy_port = {
>    port_no: uint16;
>    hw_addr: eaddr;
>    name: string;
>    config: port_config;  
>    stp_forward: bool;
>    stp_learn: bool;
>    link_down: bool;
>    curr: phy_port_feature;
>    advertised: phy_port_feature;
>    supported: phy_port_feature;
>    peer: phy_port_feature;
> }
> 
> type port_status_reason = [ ADD | DEL | MOD ]  <======= this is line 448
> let port_status_reason_of_int = function
>  | 0 -> ADD
>  | 1 -> DEL
>  | 2 -> MOD
> and int_of_port_status_reason = function
>  | ADD -> 0
>  | DEL -> 1
>  | MOD -> 2
> and string_of_port_status_reason = function
>  | ADD -> sp "ADD"
>  | DEL -> sp "DEL"
>  | MOD -> sp "MOD"
> """
> 
> hints, suggestions, answers welcome :)
> 
> -- 
> Cheers,
> 
> R.
> 
> This message and any attachment are intended solely for the addressee and may 
> contain confidential information. If you have received this message in error, 
> please send it back to me, and immediately delete it.   Please do not use, 
> copy or disclose the information contained in this message or in any 
> attachment.  Any views or opinions expressed by the author of this email do 
> not necessarily reflect the views of the University of Nottingham.
> 
> This message has been checked for viruses but the contents of an attachment
> may still contain software viruses which could damage your computer system:
> you are advised to perform your own checks. Email communications with the
> University of Nottingham may be monitored as permitted by UK legislation.