Re: [MINI-OS PATCH 11/12] kexec: add kexec callback functionality

[Jason Andryuk <jandryuk@xxxxxxxxx>]

On Fri, Mar 21, 2025 at 5:32 AM Juergen Gross <jgross@xxxxxxxx> wrote:
>
> Add a kexec_call() macro which will provide the capability to register
> a function for being called when doing a kexec() call. The called
> functions will be called with a boolean parameter "undo" indicating
> whether a previous call needs to be undone due to a failure during
> kexec().
>
> The related loop to call all callbacks is added to kexec().
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>

> diff --git a/arch/x86/mm.c b/arch/x86/mm.c
> index f4419d95..26ede6f4 100644
> --- a/arch/x86/mm.c
> +++ b/arch/x86/mm.c
> @@ -529,7 +529,8 @@ void change_readonly(bool readonly)
>  #endif
>      }
>
> -    printk("setting %p-%p readonly\n", &_text, &_erodata);
> +    printk("setting %p-%p %s\n", &_text, &_erodata,
> +           readonly ? "readonly" : "writable");

Oh, I think this belongs in the earlier change.

With that moved, this one (and the earlier one still)

Code wise:
Reviewed-by: Jason Andryuk <jason.andryuk@xxxxxxx>

But this kexec_call() macro isn't actually used?  xenstore needs this
to prepare for kexec?

Regards,
Jason