Re: [PATCH 4/4] mini-os: remove sanity_check()

[Jürgen Groß <jgross@xxxxxxxx>]

On 22.07.24 23:35, Samuel Thibault wrote:
> Juergen Gross, le lun. 22 juil. 2024 17:01:41 +0200, a ecrit:
> > Remove the sanity_check() function, as it is used nowhere.
> >
> > Since any application linked with Mini-OS can't call sanity_check()
> > either (there is no EXPORT_SYMBOL for it), there is zero chance of
> > breaking any use case.
> Don't we still want to keep it around, at least as formal documentation
> of the expected status of the list?
Hmm, is it really worth the extra code?

There are 2 ASSERT()s I'm deleting: one testing the allocation bitmap
to match the comment further up:

/*
 * ALLOCATION BITMAP
 *  One bit per page of memory. Bit set => page is allocated.
 */

And the other one testing the linked lists being correct, which IMO
doesn't need any further documentation.


Juergen