Re: [UNIKRAFT PATCH v5 00/10] Introduce Xen Netfront driver

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hi Costin,

thanks a lot for your work. I will take it upstream. While doing this, I 
am going to remove the following line from the license header of your 
newly created files from patch no. 2 and 3 because it is in conflict 
with the BSD-3 license:
 "THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY."

Can you consent to this change?

Thanks,

Simon

On 17.11.20 09:38, Costin Lupu wrote:
> The current changes are required for supporting netfront devices. They should
> be used together with the lwip patch series because they depend on each other.
>
> These changes follow the same approach used for the design and implementation
> of the virtio-net driver.
>
> The first version of these patches was sent in 2018. Maybe the current year is
> a lucky one and we will achieve the performance to upstream these changes.
>
> Changes since v1:
> - Split into multiple patches
> - Use the new uknetdev API
>
> Changes since v2:
> - Add more info to commit messages
>
> Changes since v3:
> - Use nb_align field for queue infos
> - Add patch for enabling default drivers
>
> Changes since v4:
> - Apply reviews feedback
>
> Costin Lupu (10):
>    plat/xen: Add vif device type
>    plat/xen/drivers: Add skeleton for netfront driver
>    plat/xen/drivers/net: Configure netfront device
>    plat/xen/drivers/net: Create netfront queues
>    plat/xen/drivers/net: Configure netfront tx queue
>    plat/xen/drivers/net: Configure netfront rx queue
>    plat/xen/drivers/net: Enable/disable interrupts for rx queues
>    plat/xen/drivers/net: Start netfront device
>    plat/xen/drivers/net: Add transmit operation
>    plat/xen/drivers/net: Add receive operation
>
>   plat/xen/Config.uk                 |   8 +
>   plat/xen/Makefile.uk               |  11 +
>   plat/xen/drivers/net/exportsyms.uk |   1 +
>   plat/xen/drivers/net/netfront.c    | 860 +++++++++++++++++++++++++++++
>   plat/xen/drivers/net/netfront.h    | 147 +++++
>   plat/xen/drivers/net/netfront_xb.h |  46 ++
>   plat/xen/drivers/net/netfront_xs.c | 528 ++++++++++++++++++
>   plat/xen/include/xenbus/xenbus.h   |   1 +
>   plat/xen/xenbus/client.c           |   1 +
>   9 files changed, 1603 insertions(+)
>   create mode 100644 plat/xen/drivers/net/exportsyms.uk
>   create mode 100644 plat/xen/drivers/net/netfront.c
>   create mode 100644 plat/xen/drivers/net/netfront.h
>   create mode 100644 plat/xen/drivers/net/netfront_xb.h
>   create mode 100644 plat/xen/drivers/net/netfront_xs.c