Re: [RFCv4,07/35] plat/ofw: Export fdt_find_irq_parent_offset

[Razvan Virtan <virtanrazvan@xxxxxxxxx>]

Hi, Justin.
I think the description for fdt_find_irq_parent_offset provided in the
header file is wrong, since it describes `fdt_node_offset_by_phandle()`
from `libfdt.h` instead of `fdt_find_irq_parent_offset()`.

/**

The second argument should be something like:
@offset: offset of the node whose irq parent to find

 * fdt_find_irq_parent_offset - find the irq parent offset
 * @fdt: pointer to the device tree blob
 * @phandle: phandle value
 *

I think the detailed description below should be removed or replaced with one
that describes this function.

 * fdt_node_offset_by_phandle() returns the offset of the node
 * which has the given phandle value.  If there is more than one node
 * in the tree with the given phandle (an invalid tree), results are
 * undefined.
 *
 * returns:
 *      structure block offset of the located node (>= 0), on success
 *      -FDT_ERR_NOTFOUND, no node with that phandle exists
 *      -FDT_ERR_BADPHANDLE, given phandle value was invalid (0 or -1)
 *      -FDT_ERR_BADMAGIC,
 *      -FDT_ERR_BADVERSION,
 *      -FDT_ERR_BADSTATE,
 *      -FDT_ERR_BADSTRUCTURE, standard meanings
 */
int fdt_find_irq_parent_offset(const void *fdt, int offset);


Reviewed-by: Razvan Virtan <virtanrazvan@xxxxxxxxx>