Re: [UNIKRAFT PATCH 1/1] lib/uksp: Include limits.h

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Vlad,

I have a minor comment and I can fix while upstreaming.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>


Thanks & REgards

Sharan



On 2/5/21 2:36 AM, Vlad-Andrei Badoiu wrote:
> We remove the uk/thread.h import that we previously used
> for the STACK_MASK_TOP symbol. This symbol is now available
> by importing uk/arch/limits.h.
>
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>
> ---
>   lib/uksp/ssp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/uksp/ssp.c b/lib/uksp/ssp.c
> index 8a847f5..d7b8ac1 100644
> --- a/lib/uksp/ssp.c
> +++ b/lib/uksp/ssp.c
> @@ -30,10 +30,10 @@
>    * POSSIBILITY OF SUCH DAMAGE.
>    */
>   
> +#include <uk/arch/limits.h>
>   #include <uk/assert.h>
>   #include <uk/config.h>
>   #include <uk/ctors.h>
> -#include <uk/thread.h>
We need to include <uk/arch/lcpu.h>
>   
>   #ifdef CONFIG_LIBUKSP_VALUE_USECONSTANT
>   const unsigned long __stack_chk_guard = CONFIG_LIBUKSP_VALUE_CONSTANT;