Re: [UNIKRAFT PATCH 1/1] lib/posix-libdl: Add dlvsym stub

[Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>]

I'm relaying this message from Sergiu Moga; he couldn't reply to an
e-mail he hadn't received (he wasn't subscribed to the mailing list).

Hello Vlad,

The patch looks good!

Reviewed-by: Sergiu Moga <serjueovp@xxxxxxxxx>

Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx> writes:
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>
> ---
>  lib/posix-libdl/exportsyms.uk   | 3 ++-
>  lib/posix-libdl/include/dlfcn.h | 1 +
>  lib/posix-libdl/stubs.c         | 4 ++++
>  3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/posix-libdl/exportsyms.uk b/lib/posix-libdl/exportsyms.uk
> index 77c7a542..d570a578 100644
> --- a/lib/posix-libdl/exportsyms.uk
> +++ b/lib/posix-libdl/exportsyms.uk
> @@ -3,4 +3,5 @@ dlclose
>  dlsym
>  dlerror
>  dladdr
> -dlinfo
> \ No newline at end of file
> +dlinfo
> +dlvsym
> diff --git a/lib/posix-libdl/include/dlfcn.h b/lib/posix-libdl/include/dlfcn.h
> index 706245a5..6cb6cf52 100644
> --- a/lib/posix-libdl/include/dlfcn.h
> +++ b/lib/posix-libdl/include/dlfcn.h
> @@ -58,6 +58,7 @@ typedef struct {
>  } Dl_info;
>  int dladdr(const void *, Dl_info *);
>  int dlinfo(void *, int, void *);
> +void *dlvsym(void *handle, const char *symbol, const char *version);
>  
>  #ifdef __cplusplus
>  }
> diff --git a/lib/posix-libdl/stubs.c b/lib/posix-libdl/stubs.c
> index dbfac7d1..8f5ee384 100644
> --- a/lib/posix-libdl/stubs.c
> +++ b/lib/posix-libdl/stubs.c
> @@ -67,3 +67,7 @@ int dlinfo(void *handle __unused, int request __unused, 
> void *info __unused)
>  {
>       return 0;
>  }
> +
> +void *dlvsym(void *handle, const char *symbol, const char *version)
> +{
> +}