[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [[UNIKRAFT/APP-LIBNETTLE_TEST] 1/3] Introducing the app skeleton



Hey Cristian,

This patch looks good to me.

Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@xxxxxxxxx>

On 2021-01-28 19:26:50, cristian-vijelie <cristianvijelie@xxxxxxxxx> wrote:

Signed-off-by: cristian-vijelie
---
.gitignore | 3 +++
CODING_STYLE.md | 4 ++++
CONTRIBUTING.md | 4 ++++
COPYING.md | 35 +++++++++++++++++++++++++++++++++++
Config.uk | 7 +++++++
MAINTAINERS.md | 10 ++++++++++
README.md | 22 ++++++++++++++++++++++
kraft.yaml | 19 +++++++++++++++++++
8 files changed, 104 insertions(+)
create mode 100644 .gitignore
create mode 100644 CODING_STYLE.md
create mode 100644 CONTRIBUTING.md
create mode 100644 COPYING.md
create mode 100644 Config.uk
create mode 100644 MAINTAINERS.md
create mode 100644 README.md
create mode 100644 kraft.yaml

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..910c6c4
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
+includes
+.config*
+build
diff --git a/CODING_STYLE.md b/CODING_STYLE.md
new file mode 100644
index 0000000..5730041
--- /dev/null
+++ b/CODING_STYLE.md
@@ -0,0 +1,4 @@
+Coding Style
+============
+
+Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..14f6ac6
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,4 @@
+Contributing to Unikraft
+========================
+
+Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
diff --git a/COPYING.md b/COPYING.md
new file mode 100644
index 0000000..7d621b4
--- /dev/null
+++ b/COPYING.md
@@ -0,0 +1,35 @@
+License
+=======
+
+Unikraft LibNettle Test App
+------------------------------
+
+This repository contains an example app to build with Unikraft.
+The code is published under BSD licence:
+
+ Copyright (c) 2020, Politehnica University of Bucharest. All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ 1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+ 3. Neither the name of the copyright holder nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ POSSIBILITY OF SUCH DAMAGE.
diff --git a/Config.uk b/Config.uk
new file mode 100644
index 0000000..c7d85e0
--- /dev/null
+++ b/Config.uk
@@ -0,0 +1,7 @@
+### Invisible option for dependencies
+config APPLIBNETTLETEST_DEPENDENCIES
+ bool
+ default y
+ select LIBNETTLE
+ select LIBNETTLE_TEST
+ select LIBNEWLIBC
diff --git a/MAINTAINERS.md b/MAINTAINERS.md
new file mode 100644
index 0000000..bd3d00e
--- /dev/null
+++ b/MAINTAINERS.md
@@ -0,0 +1,10 @@
+Maintainers List
+================
+
+For notes on how to read this information, please refer to `MAINTAINERS.md` in
+the main Unikraft repository.
+
+ HELLOWORLD-UNIKRAFT
+ M: Cristian Vijelie
+ L: minios-devel@xxxxxxxxxxxxx
+ F: *
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..9a4bdda
--- /dev/null
+++ b/README.md
@@ -0,0 +1,22 @@
+# Unikraft LibNettle Test Application
+
+This application tests the correct functioning of the nettle cryptographic
+library.
+
+The application requires newlib and nettle to work. Also, the LIBNETTLE_TEST
+option should be selected for nettle in menuconfig.
+
+You should configure UK_ROOT and UK_LIBS, in Makefile, acording to your setup.
+
+Due to some keyboard intrerrupt issues, to select the test suite number, you
+must replace the -1 in guest_fs/test_nr with the desired test suite number.
+Leaving the -1 will display only the test suites and their contents.
+
+To run with kvm: the following parameters must be given to qemu:
+* -fsdev local,id=myid,path=guest_fs,security_model=none
+* -device virtio-9p-pci,fsdev=myid,mount_tag=rootfs,disable-modern=on,disable-legacy=off
+
+Known issues:
+* On linuxu platform, test suite 0 will make unikraft crash. Test suites
+ are made so unikraft won't crash.
+* Not tested on Xen.
diff --git a/kraft.yaml b/kraft.yaml
new file mode 100644
index 0000000..402a3c3
--- /dev/null
+++ b/kraft.yaml
@@ -0,0 +1,19 @@
+specification: '0.4'
+
+unikraft: '0.4'
+
+architectures:
+ x86_64: true
+ arm64: true
+
+platforms:
+ linuxu: true
+ kvm: true
+ xen: true
+
+libraries:
+ newlib: '0.4'
+ nettle:
+ version: '0.4'
+ kconfig:
+ - LIBNETTLE_TEST=y
--
2.25.1



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.