[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [[UNIKRAFT/LIBNETTLE] v3 1/3] Introducing the library skeleton



Hey Cristian,

This patch looks good to me.

Reviewed-by: Cezar Craciunoiu <cezar.craciunoiu@xxxxxxxxx>

On 2021-01-28 19:07:11, cristian-vijelie <cristianvijelie@xxxxxxxxx> wrote:

Signed-off-by: cristian-vijelie
---
.gitignore | 0
CODING_STYLE.md | 4 ++++
CONTRIBUTING.md | 4 ++++
COPYING.md | 37 +++++++++++++++++++++++++++++++++++++
Config.uk | 17 +++++++++++++++++
MAINTAINERS.md | 10 ++++++++++
README.md | 10 ++++++++++
7 files changed, 82 insertions(+)
create mode 100644 .gitignore
create mode 100644 CODING_STYLE.md
create mode 100644 CONTRIBUTING.md
create mode 100644 COPYING.md
create mode 100644 Config.uk
create mode 100644 MAINTAINERS.md
create mode 100644 README.md

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..e69de29
diff --git a/CODING_STYLE.md b/CODING_STYLE.md
new file mode 100644
index 0000000..5730041
--- /dev/null
+++ b/CODING_STYLE.md
@@ -0,0 +1,4 @@
+Coding Style
+============
+
+Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..14f6ac6
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,4 @@
+Contributing to Unikraft
+========================
+
+Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
diff --git a/COPYING.md b/COPYING.md
new file mode 100644
index 0000000..3953481
--- /dev/null
+++ b/COPYING.md
@@ -0,0 +1,37 @@
+License
+=======
+
+Unikraft Nettle wrappers
+----------------------------------
+
+This repository contains wrapper code to build Nettle cryptographic library
+with Unikraft. Each C code file in this repository should declare who is
+the copyright owner and under which terms and conditions the code is licensed.
+If such a licence note is missing, the following copyright notice will apply:
+
+ Copyright (c) Year, Institution. All rights reserved.
+
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ 1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+ 3. Neither the name of the copyright holder nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
+ ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
+ LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
+ POSSIBILITY OF SUCH DAMAGE.
\ No newline at end of file
diff --git a/Config.uk b/Config.uk
new file mode 100644
index 0000000..6b7f7c6
--- /dev/null
+++ b/Config.uk
@@ -0,0 +1,17 @@
+menuconfig LIBNETTLE
+ bool "libnettle: Symmetric and one-way cryptographic library"
+ select LIBNEWLIBC
+ select LIBUK9P if PLAT_KVM
+ select LIB9PFS if PLAT_KVM
+ select LIBVFSCORE_AUTOMOUNT_ROOTFS if PLAT_KVM
+ default y
+
+if LIBNETTLE
+ config LIBNETTLE_TEST
+ bool "Provide test suite"
+ default n
+endif
+
+choice LIBVFSCORE_ROOTFS
+ default LIBVFSCORE_ROOTFS_9PFS
+endchoice
diff --git a/MAINTAINERS.md b/MAINTAINERS.md
new file mode 100644
index 0000000..c3a227d
--- /dev/null
+++ b/MAINTAINERS.md
@@ -0,0 +1,10 @@
+Maintainers List
+================
+
+For notes on how to read this information, please refer to `MAINTAINERS.md` in
+the main Unikraft repository.
+
+ LIBNETTLE-UNIKRAFT
+ M: Cristian Vijelie
+ L: minios-devel@xxxxxxxxxxxxx
+ F: *
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..1928478
--- /dev/null
+++ b/README.md
@@ -0,0 +1,10 @@
+Nettle crypto library for Unikraft
+=============================
+
+This is the port of Nettle crypto library for Unikraft as external library.
+It requires newlibc to work. When adding the library in the dependencies list,
+the libraries should be like this:
+`...$(UK_LIBS)/nettle:$(UK_LIBS)/newlib:...`
+
+Please refer to the `README.md` as well as the documentation in the `doc/`
+subdirectory of the main unikraft repository.
--
2.25.1



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.