[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT PATCH 3/7] lib/ukblkdev: blkreq.h: Use typedef for __sector

To: Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>
From: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
Date: Tue, 22 Dec 2020 16:24:06 +0100
Cc: <minios-devel@xxxxxxxxxxxxx>
Delivery-date: Tue, 22 Dec 2020 15:24:14 +0000
List-id: Mini-os development list <minios-devel.lists.xenproject.org>

Hi Laurentiu,

good point. It is not needed in fact. The print macros are definedwithin types.h not limits.h . I will remove the include from the series.


Thanks,

Simon

On 04.12.20 12:33, Laurentiu Barbulescu wrote:

Considering that `__sz` and `__PRIsz` are defined in `include/uk/arch/types.h`, 
which is already included by `lib/ukblkdev/include/uk/blkreq.h`, i don't see 
why we have to include `uk/arch/limits.h`.

References:
- Re: [UNIKRAFT PATCH 3/7] lib/ukblkdev: blkreq.h: Use typedef for __sector
  - From: Laurentiu Barbulescu

Prev by Date: [UNIKRAFT PATCH v2 2/2] lib/ukallocpool: Instrumentation for statistics
Next by Date: Re: [UNIKRAFT PATCH 5/7] lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`
Previous by thread: Re: [UNIKRAFT PATCH 3/7] lib/ukblkdev: blkreq.h: Use typedef for __sector
Next by thread: Re: [UNIKRAFT PATCH 5/7] lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`
Index(es):
- Date
- Thread

Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.