Re: [UNIKRAFT PATCH 3/3] build: Always use -no-pie as part of LIBLDFLAGS

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 23.03.20 09:25, Razvan Deaconescu wrote:
> -no-pie is not configurable for LIBLDFLAGS. It is always part of
> LIBLDFLAGS, as -Wl,-r enforces that. If PIC/PIE is configured by
> updating COMPFLAGS/LDFLAGS, no update will be required for LIBLDFLAGS.
>
> Signed-off-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>
> ---
>   Makefile.uk | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 75adc92..50dbab4 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -18,7 +18,7 @@ CINCLUDES    += -I$(CONFIG_UK_BASE)/include
>   CXXINCLUDES  += -I$(CONFIG_UK_BASE)/include
>   GOCINCLUDES  += -I$(CONFIG_UK_BASE)/include
>   
> -LIBLDFLAGS  += -nostdinc -nostdlib -Wl,-r -Wl,-d -Wl,--build-id=none
> +LIBLDFLAGS  += -nostdinc -nostdlib -Wl,-r -Wl,-d -Wl,--build-id=none -no-pie
>   
>   # Set the text and data sections to be readable and writable. Also,
>   # do not page-align the data segment. If the output format supports
> @@ -54,5 +54,4 @@ M4FLAGS      += -DUK_VERSION=$(UK_VERSION).$(UK_SUBVERSION)
>   # override "pie" option, because some distributions will set
>   # "--enable-default-pie" by default.
>   COMPFLAGS-$(call gcc_version_ge,6,1)  += -fno-PIC
> -LIBLDFLAGS-$(call gcc_version_ge,6,1)  += -no-pie
>   LDFLAGS-$(call gcc_version_ge,6,1)    += -no-pie