Re: [UNIKRAFT/TLSF PATCH] Provide LIBTLSF_INCLUDED (invisible, always "y")

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hi Hugo,

yes, sure. This makes totally sense. I sent a v2.

Thanks,

Simon

On 13.11.20 16:55, Hugo Lefeuvre wrote:
> Uh, actually, I just realized that this patch needs to do two more things:
>
> - remove main-tree.patch from the TLSF tree (this file is now useless)
> - update README.md, since this patch removes the need to patch the main tree
>
> Hugo
>
> On Fri, Nov 13, 2020 at 03:46:52PM +0000, Hugo Lefeuvre wrote:
> > Hi Simon, looks good!
> >
> > Do you think that we could fix the typo (inline) while upstreaming?
> >
> > Hugo
> >
> > Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxxxxxxxxx>
> >
> > On Mon, Oct 19, 2020 at 12:16:56PM +0200, Simon Kuenzer wrote:
> > > Introduces 'LIBTLSF_INCLUDED' that can be used to determine if the library was
> > > included to the build. It is expected that this option is an intermediate
> > > solution until we are able to dynamically register configuration options to
> > > other libraries like 'ukboot'.
> > >
> > > Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> > > ---
> > >   Config.uk | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Config.uk b/Config.uk
> > > index d74c0a5..71bff7b 100644
> > > --- a/Config.uk
> > > +++ b/Config.uk
> > > @@ -1,3 +1,9 @@
> > > +# Invisible option that is used to detect
> > > +# if LIBTLSF is availbale for configuration
> > s/availbale/available/
> >
> > > +config LIBTLSF_INCLUDED
> > > +          bool
> > > +          default y
> > > +
> > >   menuconfig LIBTLSF
> > >            bool "tlsf - dynamic memory allocator for embedded systems"
> > >            default y
> > > --
> > > 2.20.1
> > --
> >                  Hugo Lefeuvre (hle)    |    www.owl.eu.com
> > RSA4096_ 360B 03B3 BF27 4F4D 7A3F D5E8 14AA 1EB8 A247 3DFD
> > ed25519_ 37B2 6D38 0B25 B8A2 6B9F 3A65 A36F 5357 5F2D DC4C