Re: [UNIKRAFT/APPHELLOWORLD PATCH 1/6] Add comment to closing of feature macros (`#endif`)

[felipehuici <felipehuici@xxxxxxxxx>]

Hi Simon,

This patch looks good.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Mon, Sep 14, 2020 at 3:48 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Applies best practices for feature macros with multi-line code blocks:
> Adds a comment with the corresponding feature macro name after `#endif`
> directive.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  main.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/main.c b/main.c
> index c442058..a0d6a73 100644
> --- a/main.c
> +++ b/main.c
> @@ -20,13 +20,14 @@ static const char *spinner[] = {
>         " <'((<       ",
>         "<'((<        ",
>  };
> -#endif
> +#endif /* CONFIG_APPHELLOWORLD_SPINNER */
>
>  int main(int argc, char *argv[])
>  {
>  #if CONFIG_APPHELLOWORLD_PRINTARGS || CONFIG_APPHELLOWORLD_SPINNER
>         int i;
>  #endif
> +
>         printf("Hello world!\n");
>
>  #if CONFIG_APPHELLOWORLD_PRINTARGS
> @@ -34,7 +35,7 @@ int main(int argc, char *argv[])
>         for (i=0; i<argc; ++i)
>                 printf(" \"%s\"", argv[i]);
>         printf("\n");
> -#endif
> +#endif /* CONFIG_APPHELLOWORLD_PRINTARGS */
>
>  #if CONFIG_APPHELLOWORLD_SPINNER
>         i = 0;
> @@ -44,5 +45,5 @@ int main(int argc, char *argv[])
>                 printf("\r%s", spinner[i++]);
>                 sleep(1);
>         }
> -#endif
> +#endif /* CONFIG_APPHELLOWORLD_SPINNER */
>  }
> --
> 2.20.1
>
>