Re: [UNIKRAFT PATCH] include: uk/page.h: Provide __PAGE_SIZE

[Gaulthier Gain <Gaulthier.Gain@xxxxxxxxx>]

Hi Simon, Hugo, 

Using `<uk/asm/limits.h>` breaks the build with ramfs. What do you think of using  `<uk/arch/limits.h>` instead of  `<uk/asm/limits.h>`?

Gaulthier

On 28 Jul 2020, at 15:20, Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx> wrote:

Hi Simon,

thanks a lot, this looks good to me. It was confusing to me that
including page.h didn't define __PAGE_SIZE.

regards,
Hugo

Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>

On Tue, 2020-07-28 at 13:14 +0200, Simon Kuenzer wrote:

Provides __PAGE_SIZE with the uk/page.h header.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
 include/uk/page.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/uk/page.h b/include/uk/page.h
index 48ae9602..4e95f1b6 100644
--- a/include/uk/page.h
+++ b/include/uk/page.h
@@ -35,6 +35,7 @@
 #ifndef __UK_PAGE_H__
 #define __UK_PAGE_H__
 
+#include <uk/asm/limits.h>
 #include <uk/essentials.h>
 
 #ifdef __cplusplus