Re: [UNIKRAFT PATCH 1/5] lib/ukmpi: Introduce simple ring interface KConfig option

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Hi Alexander,

Please see inline.

On 7/20/20 7:40 PM, Alexander Jung wrote:
> From: Alexander Jung <alexander.jung@xxxxxxxxx>
> 
> This commit prepares UKMPI for the inclusion of a simple ring
> buffer implementation as a selectable option.
> 
> Signed-off-by: Alexander Jung <alexander.jung@xxxxxxxxx>
> ---
>  lib/ukmpi/Config.uk | 23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/ukmpi/Config.uk b/lib/ukmpi/Config.uk
> index 0c3bb4c..da50ccd 100644
> --- a/lib/ukmpi/Config.uk
> +++ b/lib/ukmpi/Config.uk
> @@ -7,7 +7,8 @@ menuconfig LIBUKMPI
>               Provide inter-thread communication primitives
>  
>  if LIBUKMPI
> -     config LIBUKMPI_MBOX
> +
> +config LIBUKMPI_MBOX
>       bool "Mailboxes"
>       select LIBUKALLOC
>       select LIBUKLOCK
> @@ -15,4 +16,24 @@ if LIBUKMPI
>       default n
>       help
>               Provide mailbox communication interface
> +
> +config LIBUKMPI_RING
> +     bool "Ring buffers"
> +     select LIBUKALLOC
> +     select LIBUKLOCK
> +     select LIBUKLOCK_SEMAPHORE
> +     default n
> +     help
> +             Provide simple ring interface for handling object references
> +
> +if LIBUKMPI_RING
> +
> +config LIBUKMPI_RING_DEBUG
> +     bool "Debug ring buffer"
> +     default n
> +     help
> +             Debug the ring interface
> +

AFAIK, debugging should be enabled by instrumenting the lib Makefile (or
the code) by defining the UK_DEBUG macro. I did not find any other lib
defining its own debug config option. Therefore we can get rid of this
option.

> +endif
> +
>  endif
>