Re: [UNIKRAFT PATCH] lib/syscall_shim: Add option to enable debugging

[Gaulthier Gain <Gaulthier.Gain@xxxxxxxxx>]

Reviewed-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>

On 20 May 2020, at 18:41, Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:

Adds an option to enable debug messages for the syscall_shim library only.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
lib/syscall_shim/Config.uk   | 4 ++++
lib/syscall_shim/Makefile.uk | 1 +
2 files changed, 5 insertions(+)

diff --git a/lib/syscall_shim/Config.uk b/lib/syscall_shim/Config.uk
index 9c39ed2f..1d90cf7f 100644
--- a/lib/syscall_shim/Config.uk
+++ b/lib/syscall_shim/Config.uk
@@ -34,4 +34,8 @@ if LIBSYSCALL_SHIM
requests (e.g., sysenter/sysexit). The handler maps
register values accordingly to the Linux ABI standard
(see: man syscalls[2]).
+
+ config LIBSYSCALL_SHIM_DEBUG
+ bool "Enable debug messages"
+ default n
endif
diff --git a/lib/syscall_shim/Makefile.uk b/lib/syscall_shim/Makefile.uk
index 37805c82..55d7488e 100644
--- a/lib/syscall_shim/Makefile.uk
+++ b/lib/syscall_shim/Makefile.uk
@@ -102,6 +102,7 @@ CINCLUDES-y   += -I$(LIBSYSCALL_SHIM_BASE)/include
CXXINCLUDES-y += -I$(LIBSYSCALL_SHIM_BASE)/include

LIBSYSCALL_SHIM_CINCLUDES += -I$(LIBSYSCALL_SHIM_BASE)
+LIBSYSCALL_SHIM_COMPFLAGS-$(CONFIG_LIBSYSCALL_SHIM_DEBUG) += -DUK_DEBUG

LIBSYSCALL_SHIM_SRCS-y += $(LIBSYSCALL_SHIM_BUILD)/uk_syscall.c
LIBSYSCALL_SHIM_SRCS-y += $(LIBSYSCALL_SHIM_BUILD)/uk_syscall6.c
--
2.20.1