Re: [UNIKRAFT/VFSCORE PATCH] Quotes to symbol

[Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>]

Hi,

looks fine to me. `default $(UK_ARCH)` is the only occurrence that does
not have quotes in the root Config.uk.

Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>

On Thu, 2020-05-21 at 23:22 +0300, George Muraru wrote:
> Add quotes to string symbol
> Got a warning while trying to use "make kmenuconfig" saying the
> following:
> "warning: style: quotes recommended around default value for string
> symbol
> UK_ARCH (defined at .../unikraft/Config.uk:12)"
> 
> Signed-off-by: George Muraru <murarugeorgec@xxxxxxxxx>
> ---
>  Config.uk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Config.uk b/Config.uk
> index 3235b91..1d4143e 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -14,7 +14,7 @@ config UK_ARCH
>       default "x86_64" if ARCH_X86_64
>       default "arm64"  if ARCH_ARM_64
>       default "arm"   if ARCH_ARM_32
> -     default $(UK_ARCH)
> +     default "$(UK_ARCH)"
>  
>  config NO_APP
>       def_bool $(shell,test $(UK_BASE) = $(UK_APP) && echo y ||
> echo n)