Re: [UNIKRAFT/LIB-PCRE V2] Makefile.uk: Update symbolic link generation

["Jung, Alexander" <a.jung@xxxxxxxxxxxxxxx>]

There are two solves for this problem, this is the first and 
better approach.

The alternative is simply add pcre_chartables.c.dist to the list
of LIBPCRE_PREPARED_DEPS.  This will prevent the file from being
targeted by make on subsequent builds (wherein this patch fixes).
However, after reviewing the pcre source code itself, it also
uses the -f flag to distribute the .dist file thus making this
the better solve.

Thanks!

Reviewed-by: Alexander Jung <a.jung@xxxxxxxxxxx>

On 27.04.20, 15:57, "minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx" <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf 
of gaulthier.gain@xxxxxxxxx> wrote:

From: gaulthier gain <gaulthier.gain@xxxxxxxxx>

During the creation of the "pcre_chartables.c" symlink, an error
can appear if the file already exists. This patch fixes this issue
by adding the -f option which removes existing destination files.

Changes v2:
- In addition, we also updated the label with "HOSTLN".

Signed-off-by: gaulthier gain <gaulthier.gain@xxxxxxxxx>
---
 Makefile.uk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.uk b/Makefile.uk
index fee51c8..0444c7d 100644
--- a/Makefile.uk
+++ b/Makefile.uk
@@ -122,8 +122,8 @@ $(LIBPCRE_EXTRACTED)/config.status: $(LIBPCRE_BUILD)/.origin

 # Create pcre_chartables.c symlink
 $(LIBPCRE_EXTRACTED)/pcre_chartables.c: $(LIBPCRE_EXTRACTED)/config.status
-       $(call verbose_cmd,LINK,libpcre: $(notdir $@), \
-               cd $(LIBPCRE_EXTRACTED) && ln -s pcre_chartables.c.dist $@)
+       $(call verbose_cmd,HOSTLN,libpcre: $(notdir $@), \
+               cd $(LIBPCRE_EXTRACTED) && ln -fs pcre_chartables.c.dist $@)

 LIBPCRE_PREPARED_DEPS = \
        $(LIBPCRE_EXTRACTED)/config.status \
-- 
2.17.1