Re: [UNIKRAFT PATCH] mm.c: Rename function call to _arch_rebuild_p2m

[Radu Nicolau <radunicolau102@xxxxxxxxx>]

Hello Costin,

The function definition is already named _arch_rebuild_p2m so this patch only renames the use to match the definition.

The reason it is named differently is an oversight by me when I introduced the function.

Cheers,

Radu

On Mon, Apr 20, 2020 at 3:37 PM Costin Lupu <costin.lupu@xxxxxxxxx> wrote:

Hi Radu,

Shouldn't you also rename the function definition?

Cheers,
Costin

On 4/19/20 12:27 PM, Radu Nicolau wrote:
> Signed-off-by: Radu Nicolau <radunicolau102@xxxxxxxxx>
> ---
>  plat/xen/x86/mm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plat/xen/x86/mm.c b/plat/xen/x86/mm.c
> index 249b792..e006ab7 100644
> --- a/plat/xen/x86/mm.c
> +++ b/plat/xen/x86/mm.c
> @@ -743,7 +743,7 @@ void arch_mm_pre_suspend(void)
>  void arch_mm_post_suspend(int canceled)
>  {
>       if (!canceled)
> -             arch_rebuild_p2m();
> +             _arch_rebuild_p2m();
>  }
>  #endif
>  #endif /* CONFIG_XEN_PV_BUILD_P2M */
>