Re: [UNIKRAFT PATCH] blkfront.c: Increase error verbosity

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 4/19/20 12:27 PM, Radu Nicolau wrote:
> Add error message for both function calls to differentiate
> which one produced an error.
> 
> Signed-off-by: Radu Nicolau <radunicolau102@xxxxxxxxx>
> ---
>  plat/xen/drivers/blk/blkfront_xs.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/plat/xen/drivers/blk/blkfront_xs.c 
> b/plat/xen/drivers/blk/blkfront_xs.c
> index 67c8a4c..e014d90 100644
> --- a/plat/xen/drivers/blk/blkfront_xs.c
> +++ b/plat/xen/drivers/blk/blkfront_xs.c
> @@ -506,12 +506,18 @@ int blkfront_xb_connect(struct blkfront_dev *blkdev)
>       }
>  
>       err = xenbus_switch_state(XBT_NIL, xendev, XenbusStateConnected);
> -     if (err)
> +     if (err) {
> +             uk_pr_err("Failed to switch state to XenbusStateConnected: 
> %d.\n",
> +                             err);
>               goto err;
> +     }
> +
>  
>       err = blkfront_xb_wait_be_connect(blkdev);
> -     if (err)
> +     if (err) {
> +             uk_pr_err("Backend failed to change state: %d.\n", err);
>               goto err;
> +     }
>  
>       err = blkfront_xb_get_capabilities(blkdev);
>       if (err) {
>