Re: [UNIKRAFT/LIB-PCRE] Makefile.uk: Add -f argument to ln

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hi Gaulthier,

thanks a lot for your work. A brief comment:

On 15.04.20, 13:00, "Minios-devel on behalf of gaulthier.gain@xxxxxxxxx" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
gaulthier.gain@xxxxxxxxx> wrote:

    From: gaulthier gain <gaulthier.gain@xxxxxxxxx>
    
    During the creation of the "pcre_chartables.c" symlink, an error
    can appear if the file already exists. This patch fixes this issue
    by adding the -f option which removes existing destination files.
    
    Signed-off-by: gaulthier gain <gaulthier.gain@xxxxxxxxx>
    ---
     Makefile.uk | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index fee51c8..d097ede 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -123,7 +123,7 @@ $(LIBPCRE_EXTRACTED)/config.status: 
$(LIBPCRE_BUILD)/.origin
     # Create pcre_chartables.c symlink
     $(LIBPCRE_EXTRACTED)/pcre_chartables.c: $(LIBPCRE_EXTRACTED)/config.status
        $(call verbose_cmd,LINK,libpcre: $(notdir $@), \
    -           cd $(LIBPCRE_EXTRACTED) && ln -s pcre_chartables.c.dist $@)
    +           cd $(LIBPCRE_EXTRACTED) && ln -fs pcre_chartables.c.dist $@)

Can you use $(HOSTLN) instead? The label should also be LN instead of LINK.

     
     LIBPCRE_PREPARED_DEPS = \
        $(LIBPCRE_EXTRACTED)/config.status \
    -- 
    2.17.1
    
    
Thanks a lot,

Simon