Re: [UNIKRAFT PATCH] lib/ukdebug: always provide uk_asmdumpk

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

This is correct, thanks a lot for this fix!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 08.04.20 14:20, Hugo Lefeuvre wrote:
> uk_asmdumpk is called in do_unhandled_trap, do_gp_fault, etc. regardless
> of CONFIG_LIBUKDEBUG_PRINTK. The builds therefore fails if
> CONFIG_LIBUKDEBUG_PRINTK is disabled.
>
> Signed-off-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>
> ---
>   lib/ukdebug/include/uk/asmdump.h | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/lib/ukdebug/include/uk/asmdump.h b/lib/ukdebug/include/uk/asmdump.h
> index a046881..93ef65d 100644
> --- a/lib/ukdebug/include/uk/asmdump.h
> +++ b/lib/ukdebug/include/uk/asmdump.h
> @@ -114,11 +114,9 @@ static inline void uk_asmdumpd(const void *instr __unused,
>                                unsigned int instr_count __unused)
>   {}
>   
> -#if CONFIG_LIBUKDEBUG_PRINTK
>   static inline void uk_asmdumpk(int lvl __unused, const void *instr __unused,
>                                unsigned int instr_count __unused)
>   {}
> -#endif /* CONFIG_LIBUKDEBUG_PRINTK */
>   
>   #endif /* Backends */
>