[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [UNIKRAFT/LIBNEWLIB PATCH] Make sure floating point is enabled when ARM64 is selected.
- To: Felipe Huici <felipe.huici@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
- From: Justin He <Justin.He@xxxxxxx>
- Date: Fri, 10 Apr 2020 13:02:28 +0000
- Accept-language: en-US, zh-CN
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jeYrVFtshPVgbesm8jBXqSL3e3rTi9pCiYq667p9b7Y=; b=gqCic8cmi/+46iDj35wNmIDHasAgx0kMFT/2h5obXTu1HXZ9hsMvmRocygOLsIQAZmFHEZXWiQrG435qXP3jcLaK8+7tGyEQtx3TZ+jOpV9K0Rc0Fk8SiGfgdHGk7slwTsI2S8A4Pqv/00u3FDs3YM+uCgv9BiTz9iqkQHArm2WKnkxVyEF/HEeSFgvkxgEmklyION8a9l+SxUBsZX2WhFtBKepHcCZg/KRTcdF80iHQDSUuZiXXdIa7kWTHFN27icClCHS4UTDMXLvmtv0s68sJyXwrRs7uRw2oTIm+9mCMHyQIZh1RJ2dk8h5mxTxratqzZslY9zbvem2ZfpG5fA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gk4a9Xi0aUvAgCZ7vz1UcJcjlqcVZnygnZx/fjrXPDUDcQUFAMnKAbPU55YCkOyzjphchuck9SADdzF1UgpJ8Hytfu0jW2fxX4vHWK/hGj0hV/LGORalqWSxq3I+fBi+TV4btA/momPv6XCSemj9xK7E2vnMOhwiFTKmg/FHUTOSi0ARHPyPjJ/ueQM+gsfdOPGmUEykNBZTBBDSDXPwkxDvErb9r9BuuZZGZ2qIAVVcTV+2gwODisROAMqsSiidv+a1MDudWMplMNvmE4VUeCLojuxhaj+YADRUH1amTP4hOCeX3q1yid8LinMd844OTCW1soMJX0kBNKlhiAoajw==
- Authentication-results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.xen.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.xen.org; dmarc=bestguesspass action=none header.from=arm.com;
- Authentication-results-original: spf=none (sender IP is ) smtp.mailfrom=Justin.He@xxxxxxx;
- Delivery-date: Fri, 10 Apr 2020 13:02:45 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: spf=none (sender IP is ) smtp.mailfrom=Justin.He@xxxxxxx;
- Thread-index: AQHWDwRR1X0+sE0v2Uetrgi9KJ56VqhyUltg
- Thread-topic: [UNIKRAFT/LIBNEWLIB PATCH] Make sure floating point is enabled when ARM64 is selected.
Looks good to me
Reviewed-by: Jia He <justin.he@xxxxxxx>
> -----Original Message-----
> From: Minios-devel <minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx> On Behalf
> Of Felipe Huici
> Sent: Friday, April 10, 2020 2:50 PM
> To: minios-devel@xxxxxxxxxxxxx
> Cc: Felipe Huici <felipe.huici@xxxxxxxxx>
> Subject: [UNIKRAFT/LIBNEWLIB PATCH] Make sure floating point is enabled
> when ARM64 is selected.
>
> newlib requires floating point support. This patch ensures that
> floating point is enabled whenever ARM64 is selected as the
> architecture.
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
> Config.uk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Config.uk b/Config.uk
> index ab127f0..533c87c 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -13,6 +13,7 @@ menuconfig LIBNEWLIBC
> select LIBVFSCORE
> select LIBPOSIX_PROCESS
> select LIBPOSIX_USER
> +select FPSIMD if ARCH_ARM_64
>
> if LIBNEWLIBC
> config LIBNEWLIBC_WANT_IO_C99_FORMATS
> --
> 2.20.1
>
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
|
