Re: [Minios-devel] [UNIKRAFT PATCH v3 5/7] arch/arm64: Don't pass -mgeneral-regs-only when CONFIG_FLOAT_POINT is y

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Justin,

This patch is fine.

Thanks & Regards

Sharan

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>

On 4/2/20 6:18 AM, Jia He wrote:
> Support CONFIG_FLOAT_POINT in Unikraft app will take some overhead during
> context switch. Hence still use -mgeneral-regs-only when
> CONFIG_FLOAT_POINT is 'n'
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   arch/arm/arm64/Makefile.uk | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/arm64/Makefile.uk b/arch/arm/arm64/Makefile.uk
> index 77e5204..af6432c 100644
> --- a/arch/arm/arm64/Makefile.uk
> +++ b/arch/arm/arm64/Makefile.uk
> @@ -3,7 +3,12 @@
>   # we should not enable the FP & SIMD access for kernel. As GCC will
>   # the FP & SIMD registers to pass parameters, we use -mgeneral-regs-only
>   # flag to force GCC to use generic registers
> +ifeq ($(CONFIG_FLOAT_POINT),y)
> +ARCHFLAGS     += -D__ARM_64__
> +else
>   ARCHFLAGS     += -D__ARM_64__ -mgeneral-regs-only
> +endif
> +
>   ISR_ARCHFLAGS += -D__ARM_64__ -mgeneral-regs-only
>   
>   # Disable FPU for trap/exception/interrupt handlers
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel