Re: [Minios-devel] [UNIKRAFT PATCH v3 1/7] plat: build: Add a config option to enable fp on arm64

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Justin,

please find the comments inline:

Thanks & Regards

Sharan

On 4/2/20 6:18 AM, Jia He wrote:
> This config is to enable the support for arm64 fp feature. Fp is for
> application only, never for Unkraft kernel itself.
>
> This config is 'n' by default since there is some overhead during context
> switch.
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   plat/Config.uk | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/plat/Config.uk b/plat/Config.uk
> index 0eb5a10..f555f17 100644
> --- a/plat/Config.uk
> +++ b/plat/Config.uk
> @@ -21,3 +21,10 @@ config HZ
>         help
>                 Configure the timer interrupt frequency.
>                 Only change this if you know what you're doing.
> +
> +config FLOAT_POINT
> +       bool "arm64 floating point support in application"
I would remove the arm64 and keep it "floating point support in 
application as this option is only visible when arm64 build are enabled.
> +       default n
> +       depends on ARCH_ARM_64
> +       help
> +               Enable support FPU usage in application
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel