Re: [Minios-devel] [UNIKRAFT/EIGEN PATCH 1/1] Update eigen version

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi George, looks good to me, thanks!

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Sat, Apr 4, 2020 at 8:04 PM George Muraru <murarugeorgec@xxxxxxxxx> wrote:
>
> Signed-off-by: George Muraru <murarugeorgec@xxxxxxxxx>
> ---
>  CONTRIBUTING.md |  2 +-
>  Config.uk       |  7 +++++++
>  Makefile.uk     | 20 +++++++-------------
>  exportsyms.uk   |  1 -
>  4 files changed, 15 insertions(+), 15 deletions(-)
>  delete mode 100644 exportsyms.uk
>
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 5f55eca..14f6ac6 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -1,4 +1,4 @@
>  Contributing to Unikraft
> -=======================
> +========================
>
>  Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
> diff --git a/Config.uk b/Config.uk
> index e5b3642..e224b69 100644
> --- a/Config.uk
> +++ b/Config.uk
> @@ -1,4 +1,11 @@
>  menuconfig LIBEIGEN
>      bool "eigen - C++ template library for linear algebra"
>      select LIBCXX
> +    select LIBCXXABI
> +    select LIBNEWLIBC
> +    select LIBUNWIND
> +    select LIBPOSIX_SYSINFO
> +    select LIBCOMPILER_RT
> +    select LIBCOMPILER_RT_ATOMIC
> +    select LIBPTHREAD_EMBEDDED
>      default n
> diff --git a/Makefile.uk b/Makefile.uk
> index 61fe366..24dc764 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -36,26 +36,20 @@
>  
> ################################################################################
>  $(eval $(call addlib_s,libeigen,$(CONFIG_LIBEIGEN)))
>
> -ifeq ($(CONFIG_LIBEIGEN),y)
> -ifneq ($(CONFIG_LIBCXX),y)
> -$(error Require libcxx)
> -endif
> -endif
> -
> -
>  
> ################################################################################
>  # Sources
>  
> ################################################################################
> -LIBEIGEN_VERSION=3.3.7
> -LIBEIGEN_URL=http://bitbucket.org/eigen/eigen/get/3.3.7.tar.gz
> +LIBEIGEN_COMMIT=049af2f56331
>  LIBEIGEN_PATCHDIR=$(LIBEIGEN_BASE)/patches
> +
> +LIBEIGEN_URL=https://bitbucket.org/eigen/eigen/get/${LIBEIGEN_COMMIT}.tar.gz
>  $(eval $(call fetch,libeigen,$(LIBEIGEN_URL)))
> -$(eval $(call patch,libeigen,$(LIBEIGEN_PATCHDIR),eigen-eigen-323c052e1731))
> +$(eval $(call 
> patch,libeigen,$(LIBEIGEN_PATCHDIR),eigen-eigen-$(LIBEIGEN_COMMIT)))
>
>  
> ################################################################################
>  # Helpers
>  
> ################################################################################
> -LIBEIGEN_SUBDIR=eigen-eigen-323c052e1731
> +LIBEIGEN_SUBDIR=eigen-eigen-$(LIBEIGEN_COMMIT)
>  LIBEIGEN_SRC=$(LIBEIGEN_ORIGIN)/$(LIBEIGEN_SUBDIR)
>
>  
> ################################################################################
> @@ -79,5 +73,5 @@ SUPPRESS_FLAGS += -Wno-unused-parameter 
> -Wno-unused-variable -Wno-nonnull     \
>  -Wno-missing-braces -Wno-endif-labels -Wno-unused-but-set-variable           
>   \
>  -Wno-implicit-function-declaration -Wno-type-limits -Wno-sign-compare
>
> -LIBEIGEN_CFLAGS-y    +=  $(SUPPRESS_FLAGS)
> -LIBEIGEN_CXXFLAGS-y    +=  $(SUPPRESS_FLAGS)
> +LIBEIGEN_CFLAGS-y += $(SUPPRESS_FLAGS)
> +LIBEIGEN_CXXFLAGS-y += $(SUPPRESS_FLAGS)
> diff --git a/exportsyms.uk b/exportsyms.uk
> deleted file mode 100644
> index 621e94f..0000000
> --- a/exportsyms.uk
> +++ /dev/null
> @@ -1 +0,0 @@
> -none
> --
> 2.17.1
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel