Re: [Minios-devel] [UNIKRAFT/LIBPTHREADPOOL PATCH] Freeze the library against a particular commit hash.

[Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>]

Thank you!

Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>

On 02.04.2020 12:43, Felipe Huici wrote:
> Currently pthreadpool builds against master. Since master changes,
> this makes the build of this library brittle; in this patch we freeze
> against one of the latest commits.
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx>
> ---
>   Makefile.uk | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 6944c74..d62f305 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -39,15 +39,15 @@ $(eval $(call 
> addlib_s,libpthreadpool,$(CONFIG_LIBPTHREADPOOL)))
>   
> ################################################################################
>   # Sources
>   
> ################################################################################
> -LIBPTHREADPOOL_VERSION=master
> -LIBPTHREADPOOL_URL=https://github.com/Maratyszcza/pthreadpool/archive/master.zip
> +LIBPTHREADPOOL_VERSION=76042155a8b1e189c8f141429fd72219472c32e1
> +LIBPTHREADPOOL_URL=https://github.com/Maratyszcza/pthreadpool/archive/$(LIBPTHREADPOOL_VERSION).zip
>   LIBPTHREADPOOL_PATCHDIR=$(LIBPTHREADPOOL_BASE)/patches
>   $(eval $(call fetch,libpthreadpool,$(LIBPTHREADPOOL_URL)))
>   
>   ################################################################################
>   # Helpers
>   
> ################################################################################
> -LIBPTHREADPOOL_SUBDIR=pthreadpool-master
> +LIBPTHREADPOOL_SUBDIR=pthreadpool-$(LIBPTHREADPOOL_VERSION)
>   LIBPTHREADPOOL_SRC=$(LIBPTHREADPOOL_ORIGIN)/$(LIBPTHREADPOOL_SUBDIR)
>   
>   ################################################################################
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel