Re: [Minios-devel] [UNIKRAFT PATCH] build: Remove flag -fms-extensions for CFLAGS

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks a lot for looking into this.

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 31.03.20 09:25, Jia He wrote:
> Commit cec8989904ac ("build: Introduce COMPFLAGS(-y) and ARCHFLAGS(-y)")
> moved -fms-extensions from arm arch to global CFLAGS
>
> Here is the introduction from "man gcc"
>    Accept some non-standard constructs used in Microsoft header files.
>
>    In C++ code, this allows member names in structures to be similar to
>    previous types declarations.
>
>    typedef int UOW;
>    struct ABC {
>      OW UOW;
>    };
>
>    Some cases of unnamed fields in structures and unions are only accepted
>    with this option.
>
> Hence, if Unikraft doesn't include any non-standard constructs used in
> Microsoft header files, we can remove it.
>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>   Makefile.uk | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index a78afc0..1d6d060 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -9,8 +9,6 @@ COMPFLAGS    += -U __linux__ -U __FreeBSD__ -U __sun__
>   COMPFLAGS    += -fno-stack-protector -fno-omit-frame-pointer -fno-tree-sra
>   COMPFLAGS    += -Wall -Wextra
>   
> -# TODO: Remove -fms-extensions if not needed for our code (it was moved from Arm64 arch)
> -CFLAGS       += -fms-extensions
>   ASFLAGS      += -D__ASSEMBLY__
>   
>   ASINCLUDES   += -I$(CONFIG_UK_BASE)/include
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel