Re: [Minios-devel] [UNIKRAFT PATCH v2 3/6] build: Rename C++ buildrule to buildrule_cxx

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 13.03.20, 12:56, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    This is done for consistency reasons. Build-related variables for C++
    units are also prefixed with CXX instead of CC.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     support/build/Makefile.rules | 14 +++++++-------
     1 file changed, 7 insertions(+), 7 deletions(-)
    
    diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
    index 078bafe3..c4eb86ee 100644
    --- a/support/build/Makefile.rules
    +++ b/support/build/Makefile.rules
    @@ -448,7 +448,7 @@ $(eval $(call vprefix_lib,$(1),OBJS-y) += $(4))
     $(eval $(call vprefix_lib,$(1),CLEAN-y) += $(call build_clean,$(4)) $(call 
out2dep,$(4)))
     endef
     
    -define buildrule_cc =
    +define buildrule_cxx =
     $(4): $(2) | prepare
        $(call build_cmd_fixdep,CXX,$(1),$(4),\
                $(CXX) $(CXXINCLUDES) $(CXXINCLUDES-y) \
    @@ -471,12 +471,12 @@ $(eval $(call vprefix_lib,$(1),CLEAN-y) += $(call 
build_clean,$(4)) $(call out2d
     endef
     
     # Aliases for C++ sources
    -buildrule_cp  = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    -buildrule_cxx = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    -buildrule_cpp = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    -buildrule_CPP = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    -buildrule_C   = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    -buildrule_c$(plus)$(plus) = $(call buildrule_cc,$(1),$(2),$(3),$(4))
    +buildrule_cp  = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
    +buildrule_cc  = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
    +buildrule_cpp = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
    +buildrule_CPP = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
    +buildrule_C   = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
    +buildrule_c$(plus)$(plus) = $(call buildrule_cxx,$(1),$(2),$(3),$(4))
     
     define buildrule_go =
     $(4): $(2) | prepare
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel