Re: [Minios-devel] [UNIKRAFT PATCH v2 1/6] build: buildrule: Strip arguments

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 13.03.20, 12:56, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    Strip leading and trailing whitespaces from all given arguments
    at the buildrule demultiplexer `buildrule`. This removes unexpected
    behavior because of white spaces when implementing a buildrule.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     support/build/Makefile.rules | 6 +++---
     1 file changed, 3 insertions(+), 3 deletions(-)
    
    diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
    index 16a55674..a4f1be66 100644
    --- a/support/build/Makefile.rules
    +++ b/support/build/Makefile.rules
    @@ -552,10 +552,10 @@ endef
     buildrule_ = $(error $(1): Failed to derive source type from $(2))
     
     define buildrule =
    -$(if $(filter buildrule_$(call fileext,$(2)),$(.VARIABLES)),,\
    -$(error buildrule_$(call fileext,$(2)) is not defined: Failed to install 
rule for $(2)))
    +$(if $(filter buildrule_$(call fileext,$(strip $(2))),$(.VARIABLES)),,\
    +$(error buildrule_$(call fileext,$(strip $(2))) is not defined: Failed to 
install rule for $(2)))
     
    -$(call buildrule_$(call fileext,$(2)),$(1),$(2),$(3),$(4))
    +$(call buildrule_$(call fileext,$(strip $(2))),$(strip $(1)),$(strip 
$(2)),$(strip $(3)),$(strip $(4)))
     endef
     
     #################################################
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel