Re: [Minios-devel] [UNIKRAFT v2] lib/ukmmap: Fix return type and mark stub parameters as unused for cleaner build

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Thanks a lot for the v2. The `mremap` line crossed the 80 character 
limit. I fix it while upstreaming.
Thanks!

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 14.02.20 08:42, Felipe Huici wrote:
> Fix the return type of mremap and add __unused to its paramters to
> prevent unused parameter warnings to appear in the build (mremap is a
> stub for now).
>
> Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx
> ---
>   lib/ukmmap/mmap.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/ukmmap/mmap.c b/lib/ukmmap/mmap.c
> index 52c49e2..94a3ac4 100644
> --- a/lib/ukmmap/mmap.c
> +++ b/lib/ukmmap/mmap.c
> @@ -165,8 +165,8 @@ int munmap(void *addr, size_t len)
>         return 0;
>   }
>   
> -void *mremap(void *old_address, size_t old_size, size_t new_size,
> -               int flags, ...)
> +void *mremap(void *old_address __unused, size_t old_size __unused, size_t 
> new_size __unused,
> +               int flags __unused, ...)
>   {
> -       return -1;
> +       return NULL;
>   }
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel