Re: [Minios-devel] [UNIKRAFT/LWIP PATCH] ppoll()/generic select() only available with libc

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon, looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 12.02.20, 15:31, "Simon Kuenzer" <simon.kuenzer@xxxxxxxxx> wrote:

    The options LWIP_SOCKET_SELECT_GENERIC_FDS and LWIP_SOCKET_PPOLL are
    only made available when a proper libc (HAVE_LIBC) is added and
    enabled to the build. These options do not work with nolibc.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     Config.uk | 2 ++
     1 file changed, 2 insertions(+)
    
    diff --git a/Config.uk b/Config.uk
    index debf0c7..aaaaae0 100644
    --- a/Config.uk
    +++ b/Config.uk
    @@ -165,6 +165,7 @@ config LWIP_SOCKET
     if LWIP_SOCKET
        config LWIP_SOCKET_SELECT_GENERIC_FDS
                bool "Use select() with any file descriptor type"
    +           depends on HAVE_LIBC
                default y
                help
                        lwip's select() implementation supports only sockets. 
This
    @@ -173,6 +174,7 @@ if LWIP_SOCKET
     
        config LWIP_SOCKET_PPOLL
                bool "Enable ppoll()"
    +           depends on HAVE_LIBC
                default y
                help
                        Enable ppoll() implementation.
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel