Re: [Minios-devel] [UNIKRAFT/LIBGO PATCH] README: Update library order

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Simon, looks good, thanks.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 07.02.20, 15:37, "Minios-devel on behalf of Simon Kuenzer" 
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of 
simon.kuenzer@xxxxxxxxx> wrote:

    Update the library order so that libgo compiles.
    
    Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
    ---
     README.md | 20 ++++++++++++--------
     1 file changed, 12 insertions(+), 8 deletions(-)
    
    diff --git a/README.md b/README.md
    index 590d8d8..e00cbad 100644
    --- a/README.md
    +++ b/README.md
    @@ -4,22 +4,26 @@ libgo for Unikraft
     This is a port of libgo for Unikraft as an external library. You will
     need the following external libraries to make it work:
     
    -+ newlib
    ++ gcc
    ++ libgo
    ++ pthread-embedded
    ++ lwip
     + compiler-rt
    -+ libunwind
     + libcxx
     + libcxxabi
    -+ pthread-embedded
    -+ gcc
    -+ lwip
    ++ libunwind
     + libucontext
    ++ newlib
     
    -When adding the library in the dependency list, please make sure that
    -gcc comes before libgo, e.g.:
    +Please note that the listed order is important, in particular
    +gcc before libgo, e.g.:
     
     ```
    -...$(UK_LIBS)/gcc:$(UK_LIBS)/libgo:...
    +...$(UK_LIBS)/gcc:$(UK_LIBS)/libgo:$(UK_LIBS)/pthread-embedded...
    +
     ```
     
    +Currently, you need to assign at least 512 MB of RAM to the guest.
    +
     Please refer to the `README.md` as well as the documentation in the `doc/`
     subdirectory of the main unikraft repository.
    -- 
    2.20.1
    
    
    _______________________________________________
    Minios-devel mailing list
    Minios-devel@xxxxxxxxxxxxxxxxxxxx
    https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel