Re: [Minios-devel] [UNIKRAFT/NNPACK PATCH 1/1] Add support for ARM64

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad,

This patch looks good, I've tested on ARM64/QEMU and on an RPI b+ (bare metal).

Thanks,

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 22.01.20, 11:40, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    We define CPUINFO_ARCH_ARM64 when ARM64 is selected.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     Makefile.uk | 11 +++++++++--
     1 file changed, 9 insertions(+), 2 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 2da2af1..de7c6b4 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -59,6 +59,7 @@ LIBNNPACK_SRC = $(LIBNNPACK_ORIGIN)/$(LIBNNPACK_SUBDIR)
     LIBNNPACK_GLOBAL_INCLUDES-y += -I$(LIBNNPACK_SRC)/src
     LIBNNPACK_GLOBAL_INCLUDES-y += -I$(LIBNNPACK_SRC)/src/ref
     LIBNNPACK_GLOBAL_INCLUDES-y += -I$(LIBNNPACK_SRC)/include
    +LIBNNPACK_GLOBAL_INCLUDES-y += -I$(LIBNNPACK_SRC)/include/nnpack
     LIBNNPACK_GLOBAL_INCLUDES-y += -I$(LIBNNPACK_BASE)/include
     
     CINCLUDES-$(CONFIG_LIBNNPACK) += $(LIBNNPACK_GLOBAL_INCLUDES-y)
    @@ -78,8 +79,14 @@ LIBNNPACK_SUPPRESS_FLAGS += -Wno-unused-parameter        
                \
     LIBNNPACK_CFLAGS-y += $(LIBNNPACK_SUPPRESS_FLAGS) -Wno-pointer-to-int-cast 
-Wno-int-to-pointer-cast
     LIBNNPACK_CXXFLAGS-y       += $(LIBNNPACK_SUPPRESS_FLAGS)
     
    -LIBNNPACK_CFLAGS-y +=  -D__linux__ -DCPUINFO_ARCH_X86
    -LIBNNPACK_CXXFLAGS-y       +=  -D__linux__ -DCPUINFO_ARCH_X86
    +LIBNNPACK_CFLAGS-y +=  -D__linux__
    +LIBNNPACK_CXXFLAGS-y       +=  -D__linux__
    +
    +LIBNNPACK_CFLAGS-$(CONFIG_ARCH_X86_64)     += -DCPUINFO_ARCH_X86
    +LIBNNPACK_CXXFLAGS-$(CONFIG_ARCH_X86_64)   += -DCPUINFO_ARCH_X86
    +
    +LIBNNPACK_CFLAGS-$(CONFIG_ARCH_ARM_64)     += -DCPUINFO_ARCH_ARM64
    +LIBNNPACK_CXXFLAGS-$(CONFIG_ARCH_ARM_64)   += -DCPUINFO_ARCH_ARM64
     
     LIBNNPACK_CFLAGS-$(CONFIG_LIBNNPACK_BACKEND_PSIMD) += -DNNP_BACKEND_PSIMD
     LIBNNPACK_CXXFLAGS-$(CONFIG_LIBNNPACK_BACKEND_PSIMD)       += 
-DNNP_BACKEND_PSIMD
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel