[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Minios-devel] [UNIKRAFT PATCH 8/9] lib/vfscore: Update to <uk/ctors.h> changes
- To: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>, "minios-devel@xxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxx>
- From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
- Date: Thu, 30 Jan 2020 17:10:17 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=stud.acs.upb.ro; dmarc=pass action=none header.from=stud.acs.upb.ro; dkim=pass header.d=stud.acs.upb.ro; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXIvYdPSOU9MCKZ0atB656+akEVsoHEV7FWwKzy6XgY=; b=PMbvLTmb7C0dLL2ErgiSl8F459dCeDoumEDlscHf9exOkXk2sghufM7xkqfU/IR/7ereUP6jIWxI5cd+BWewmLwP+bx4Lg3V8Z7+uZ5/0wqpdbJsscGRM0hcayMljsKoV8X4er1UqmvCUBo5mA1YxqTi+rGCNIKQuCIv9/zO8BeeoHDc3mrWdbyQmLAT2qIACt1ECbzWwWrfcrGNR3P6647QSJ/zi9eBju/r5L0o+Ysmq828GDerC6UM91udVjW09Y+cTxGwF502hB/kXSde9ebchSXX6AQ4Gpr15boLoZ1haSOMTbl+bGH/1SrLtPj3RXMiGSNm89/e8EH5xG/Yrg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMd+yKwawR4oIB+9hHRhkFnszjwI1dFDznOKJ/qJuhJvtLmKzuTMcCD5FwujAJqJ4lsfBsrZIJj67tJHw/OmO2gaIuJwqj2bbi67L3sdBzFItFxOhC6znrJxsfMQtmCbdv1rM0MV3ltzh9TO48rHOnpNtlU4uIKwMoA9sXIjnG+IY/IB/xWzT42snJE1tqROao7Y+PKfgAKxnQgQNOn/1JVy5HYbJyk6uC3Q8G36ffBGSKGuueEnNYKbWdj66xaMI81bNJcXT0rawjgRbr7AANoKs/0pr1NoGE709ySsdKATo31b8j11y+6u3GXxhOM6D7l/qhIynIp8iaRpcfiqKQ==
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=vlad_andrei.badoiu@xxxxxxxxxxxxxxx;
- Cc: Felipe Huici <felipe.huici@xxxxxxxxx>
- Delivery-date: Thu, 30 Jan 2020 17:10:25 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
- Thread-index: AQHV1u4BzEuD9PYll0C5HgQtrOWwQ6gDcmwA
- Thread-topic: [UNIKRAFT PATCH 8/9] lib/vfscore: Update to <uk/ctors.h> changes
Please see one comment inline that does not affect the reviewing.
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
On 29.01.2020 23:49, Simon Kuenzer wrote:
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
> lib/vfscore/fd.c | 2 +-
> lib/vfscore/main.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/vfscore/fd.c b/lib/vfscore/fd.c
> index 6db366a9..6b7f5ec7 100644
> --- a/lib/vfscore/fd.c
> +++ b/lib/vfscore/fd.c
> @@ -209,4 +209,4 @@ static void fdtable_init(void)
> init_stdio();
> }
>
> -UK_CTOR_FUNC(1, fdtable_init);
> +UK_CTOR_PRIO(fdtable_init, 1);
> diff --git a/lib/vfscore/main.c b/lib/vfscore/main.c
> index b3fc2f24..ca59b046 100644
> --- a/lib/vfscore/main.c
> +++ b/lib/vfscore/main.c
> @@ -2111,4 +2111,4 @@ static void vfscore_init(void)
> lookup_init();
> }
>
> -UK_CTOR_FUNC(1, vfscore_init);
> +UK_CTOR_PRIO(vfscore_init, 1);
Maybe we should define the following macros in the header?
+#define UK_VFSCORE_INIT_CLASS UK_INIT_CLASS_EARLY
+#define UK_VFSCORE_INIT_PRIO 1
+#define UK_VFSCORE_REGISTER_PRIO 1
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
