Re: [Minios-devel] [UNIKRAFT/MUSL PATCH V2 01/28] Add support for C++ applications

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Looks fine. Longer-term we should try not to export internal headers. 
For this first release, this is fine. Thanks!
Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 29.01.20 22:18, Gaulthier Gain wrote:
> Update Makefile.uk to provide support to C++ applications.
>
> Signed-off-by: Gaulthier Gain <gaulthier.gain@xxxxxxxxx>
> ---
>   Makefile.uk | 15 ++++++++-------
>   1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index fc31a72..3937993 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -55,13 +55,14 @@ LIBMUSL=$(LIBMUSL_ORIGIN)/$(LIBMUSL_SUBDIR)/
>   
> ################################################################################
>   # Library includes
>   
> ################################################################################
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL_BASE)/include
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/include
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/arch/$(ARCH)
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/arch/generic
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/internal
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/ctype
> -CINCLUDES-$(CONFIG_LIBMUSL)   += -I$(LIBMUSL)/src/dirent
> +LIBMUSL_GLOBAL_INCLUDES-y   += -I$(LIBMUSL)/arch/$(ARCH)
> +LIBMUSL_GLOBAL_INCLUDES-y   += -I$(LIBMUSL)/arch/generic
> +LIBMUSL_GLOBAL_INCLUDES-y   += -I$(LIBMUSL)/src/internal
> +LIBMUSL_GLOBAL_INCLUDES-y   += -I$(LIBMUSL)/include
> +LIBMUSL_GLOBAL_INCLUDES-y   += -I$(LIBMUSL_BASE)/include
> +
> +CINCLUDES-y    += $(LIBMUSL_GLOBAL_INCLUDES-y)
> +CXXINCLUDES-y  += $(LIBMUSL_GLOBAL_INCLUDES-y)
>   
>   ################################################################################
>   # Musl-specific Targets
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel