Re: [Minios-devel] [UNIKRAFT PATCH] lib/ukboot: fflush() after banner is printed

[Gaulthier Gain <Gaulthier.Gain@xxxxxxxxx>]

Hi Simon, 

I tested with musl. Now, we can see the "Unikraft banner" however application 
output is not displayed.

I think that we need to fix this issue in the musl implementation. 

Gaulthier

> On 27 Jan 2020, at 10:16, Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
> 
> For the case that a libc is adding buffering `stdout`, we are flushing
> `stdout` after printing the "Welcome to Unirkaft" banner. This is to
> make sure that the output stays in order and does not get mixed with
> the kernel and debug output.
> 
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
> lib/ukboot/boot.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/lib/ukboot/boot.c b/lib/ukboot/boot.c
> index 3f5046ca..9bd15ca8 100644
> --- a/lib/ukboot/boot.c
> +++ b/lib/ukboot/boot.c
> @@ -100,6 +100,7 @@ static void main_thread_func(void *arg)
>       printf("\\_,_/_//_/_/_/\\_\\/_/  \\_,_/_/ \\__/\n");
>       printf("%35s\n",
>              STRINGIFY(UK_CODENAME) " " STRINGIFY(UK_FULLVERSION));
> +     fflush(stdout);
> #endif
>       /*
>        * Application
> -- 
> 2.20.1
> 


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel