Re: [Minios-devel] [UNIKRAFT/LIBCXXABI PATCH 1/1] Uncomment thread option checks

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad, thanks for the patch.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 14.01.20, 17:16, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    Commit 84107fa4 added an option for thread support but the Makefile
    toggle was commented.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     Makefile.uk | 8 ++++----
     1 file changed, 4 insertions(+), 4 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index 52e9114..3bc2e91 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -68,9 +68,9 @@ CXXINCLUDES-$(CONFIG_LIBCXXABI) += 
-I$(LIBCXXABI_SRC)/include
     
################################################################################
     # Global flags
     
################################################################################
    -#ifndef CONFIG_LIBCXXABI_THREADS
    +ifndef CONFIG_LIBCXXABI_THREADS
     CONFIG_FLAGS       +=      -D _LIBCXXABI_HAS_NO_THREADS
    -#endif
    +endif
     LIBCXXABI_CFLAGS-y    +=  $(CONFIG_FLAGS)
     LIBCXXABI_CXXFLAGS-y    +=  $(CONFIG_FLAGS)
     
    @@ -99,6 +99,6 @@ LIBCXXABI_SRCS-y += 
$(LIBCXXABI_SRC)/src/private_typeinfo.cpp
     LIBCXXABI_SRCS-y += $(LIBCXXABI_SRC)/src/cxa_handlers.cpp
     LIBCXXABI_SRCS-y += $(LIBCXXABI_SRC)/src/cxa_default_handlers.cpp
     LIBCXXABI_SRCS-y += $(LIBCXXABI_SRC)/src/cxa_guard.cpp
    -#ifdef CONFIG_LIBCXXABI_THREADS
    +ifdef CONFIG_LIBCXXABI_THREADS
     LIBCXXABI_SRCS-y += $(LIBCXXABI_SRC)/src/cxa_thread_atexit.cpp
    -#endif
    +endif
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel