Re: [Minios-devel] [UNIKRAFT/LIBCXX PATCH 1/1] Changes for ARM64 support

[Felipe Huici <Felipe.Huici@xxxxxxxxx>]

Hi Vlad, thanks for the patch.

-- Felipe

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On 14.01.20, 17:03, "Vlad-Andrei BĂDOIU (78692)" 
<vlad_andrei.badoiu@xxxxxxxxxxxxxxx> wrote:

    In order to compile under ARM64 we remove the definitions of __x86_64__
    __FLT16_MANT_DIG__.
    
    Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
    ---
     Makefile.uk               | 4 +---
     include/__config_unikraft | 3 +++
     2 files changed, 4 insertions(+), 3 deletions(-)
    
    diff --git a/Makefile.uk b/Makefile.uk
    index f4543a2..6f5f37c 100644
    --- a/Makefile.uk
    +++ b/Makefile.uk
    @@ -91,11 +91,9 @@ CXXINCLUDES-$(CONFIG_LIBCXX) += -I$(LIBCXX_SRC)/utils
     
################################################################################
     # Global flags
     
################################################################################
    -CONFIG_FLAGS       += -D LIBCXX_BUILDING_LIBCXXABI         \
    -           -D __x86_64__ -D _LIBCPP_STD_VER=15     \
    +CONFIG_FLAGS       += -D LIBCXX_BUILDING_LIBCXXABI -D _LIBCPP_STD_VER=15   
        \
                -D _LIBCPP_PROVIDES_DEFAULT_RUNE_TABLE -D __DYNAMIC_REENT__     
\
     
    -
     ifdef CONFIG_CXX_THREADS
     CONFIG_FLAGS += -D__linux__ -D_LIBCPP_HAS_THREAD_API_PTHREAD
     else
    diff --git a/include/__config_unikraft b/include/__config_unikraft
    index d67a232..930e3d8 100644
    --- a/include/__config_unikraft
    +++ b/include/__config_unikraft
    @@ -14,3 +14,6 @@
     #define _LIBCPP_BUILDING_LIBRARY
     #endif
     
    +#if defined( __arm__) || defined(__ARM_64__)
    +#undef __FLT16_MANT_DIG__
    +#endif
    -- 
    2.20.1
    
    

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel