|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Minios-devel] [UNIKRAFT/LCMS PATCH v3 1/3] [LCMS PATCH] lcms: Add new library
Hi Esteban,
Thanks for this series! Please see my comments inline.
-- Felipe
On 02.01.20, 13:12, "Minios-devel on behalf of Esteban Martinez"
<minios-devel-bounces@xxxxxxxxxxxxxxxxxxxx on behalf of
esteban.martinez@xxxxxxxx> wrote:
Add skeleton new library LCMS
Signed-off-by: Esteban Martinez <esteban.martinez@xxxxxxxx>
---
.gitignore | 27 +++++++++++++++++++++++++++
CODING_STYLE.md | 4 ++++
CONTRIBUTING.md | 4 ++++
COPYING.md | 41 +++++++++++++++++++++++++++++++++++++++++
Config.uk | 11 +++++++++++
MAINTAINERS.md | 11 +++++++++++
README.md | 7 +++++++
exportsyms.uk | 1 +
8 files changed, 106 insertions(+)
create mode 100755 .gitignore
create mode 100755 CODING_STYLE.md
create mode 100755 CONTRIBUTING.md
create mode 100755 COPYING.md
create mode 100755 Config.uk
create mode 100755 MAINTAINERS.md
create mode 100755 README.md
create mode 100755 exportsyms.uk
diff --git a/.gitignore b/.gitignore
new file mode 100755
index 0000000..75d2fd3
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,27 @@
+*.depend
+*.o
+*.a
+*.d
+*.so
+*.orig
+*.rej
+*.bak
+*.swp
+*~
+,*
+\#*\#
+.\#*
+\#_*\#
+.\#_*
+!.gitignore
+.*
+
+# gnu global files
+GPATH
+GRTAGS
+GSYMS
+GTAGS
+
+# cscope files
+cscope.*
+ncscope.*
diff --git a/CODING_STYLE.md b/CODING_STYLE.md
new file mode 100755
index 0000000..5730041
--- /dev/null
+++ b/CODING_STYLE.md
@@ -0,0 +1,4 @@
+Coding Style
+============
+
+Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100755
index 0000000..14f6ac6
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,4 @@
+Contributing to Unikraft
+========================
+
+Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
diff --git a/COPYING.md b/COPYING.md
new file mode 100755
index 0000000..fa05041
--- /dev/null
+++ b/COPYING.md
@@ -0,0 +1,41 @@
+License
+=======
+
+Unikraft lcms wrappers
+------------------------
+
+This repository contains wrapper code to build lcms with Unikraft. The
code
+is published as a mixture of BSD and MIT licences; each C code file in
+this repository should declare who is the copyright owner and under which
terms
+and conditions the code is licensed. If such a licence note is missing, the
+following copyright notice will apply:
+
+ Copyright (c) 2017, NEC Europe Ltd., NEC Corporation. All rights
reserved.
You should put your organization here, and update the year.
+ Redistribution and use in source and binary forms, with or without
+ modification, are permitted provided that the following conditions
+ are met:
+
+ 1. Redistributions of source code must retain the above copyright
+ notice, this list of conditions and the following disclaimer.
+ 2. Redistributions in binary form must reproduce the above copyright
+ notice, this list of conditions and the following disclaimer in the
+ documentation and/or other materials provided with the distribution.
+ 3. Neither the name of the copyright holder nor the names of its
+ contributors may be used to endorse or promote products derived from
+ this software without specific prior written permission.
+
+ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
IS"
+ AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
THE
+ IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
PURPOSE
+ ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS
BE
+ LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
THE
+ POSSIBILITY OF SUCH DAMAGE.
+
+lcms source code
+------------------
\ No newline at end of file
diff --git a/Config.uk b/Config.uk
new file mode 100755
index 0000000..edb3659
--- /dev/null
+++ b/Config.uk
@@ -0,0 +1,11 @@
+config LIBLCMS
+ bool "liblcms - Color management engine"
+ default n
+ select LIBNOLIBC if !HAVE_LIBC
You should remove the line above, lcms doesn't compile with noblic.
+ select LIBUKDEBUG
Please fix the indentation, it should all be at the same level.
+ select LIBUKALLOC
+ select LIBPTHREAD_EMBEDDED
+ select LIBNEWLIBC
+
+if LIBLCMS
+endif
diff --git a/MAINTAINERS.md b/MAINTAINERS.md
new file mode 100755
index 0000000..227c4dd
--- /dev/null
+++ b/MAINTAINERS.md
@@ -0,0 +1,11 @@
+Maintainers List
+================
+
+For notes on how to read this information, please refer to
`MAINTAINERS.md` in
+the main Unikraft repository.
+
+ LCMS-UNIKRAFT
+ M: Costin Lupu <costin.lupu@xxxxxxxxx>
+ M: Felipe Huici <felipe.huici@xxxxxxxxx>
You should at least add yourself to the maintainers list.
+ L: minios-devel@xxxxxxxxxxxxx
+ F: *
diff --git a/README.md b/README.md
new file mode 100755
index 0000000..41f3ea5
--- /dev/null
+++ b/README.md
@@ -0,0 +1,7 @@
+lcms for Unikraft
+=============================
+
+This is the port of lcms for Unikraft as external library.
+
+Please refer to the `README.md` as well as the documentation in the `doc/`
+subdirectory of the main unikraft repository.
diff --git a/exportsyms.uk b/exportsyms.uk
new file mode 100755
index 0000000..c86c3f3
--- /dev/null
+++ b/exportsyms.uk
@@ -0,0 +1 @@
+none
\ No newline at end of file
--
2.17.1
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |