Re: [Minios-devel] [UNIKRAFT RFC PATCH 1/5] plat: build: Add a config option to enable fp on arm64

[Julien Grall <julien@xxxxxxx>]

On 20/12/2019 00:56, Justin He wrote:
> Hi Julien
Hi,

> > -----Original Message-----
> > From: Julien Grall <julien@xxxxxxx>
> > Sent: Thursday, December 19, 2019 10:34 PM
> > To: Justin He <Justin.He@xxxxxxx>; minios-devel@xxxxxxxxxxxxxxxxxxxx;
> > Simon Kuenzer <simon.kuenzer@xxxxxxxxx>; Santiago.Pagani@xxxxxxxxx
> > Cc: Felipe Huici <felipe.huici@xxxxxxxxx>; Kaly Xin <Kaly.Xin@xxxxxxx>;
> > Julien Grall <Julien.Grall@xxxxxxx>; Sharan.Santhanam@xxxxxxxxx
> > Subject: Re: [Minios-devel] [UNIKRAFT RFC PATCH 1/5] plat: build: Add a
> > config option to enable fp on arm64
> >
> > Hi,
> >
> > On 19/12/2019 14:27, Jia He wrote:
> > > This config is to enable the support for arm64 fp feature. Fp is for
> > > application only, never for Unkraft kernel itself.
> > >
> > > This config is 'n' by default since there is some overhead during context
> > > switch.
> > >
> > > Signed-off-by: Jia He <justin.he@xxxxxxx>
> > > ---
> > >    plat/Config.uk | 7 +++++++
> > >    1 file changed, 7 insertions(+)
> > >
> > > diff --git a/plat/Config.uk b/plat/Config.uk
> > > index 0eb5a10..f555f17 100644
> > > --- a/plat/Config.uk
> > > +++ b/plat/Config.uk
> > > @@ -21,3 +21,10 @@ config HZ
> > >      help
> > >              Configure the timer interrupt frequency.
> > >              Only change this if you know what you're doing.
> > > +
> > > +config FLOAT_POINT
> > > +   bool "arm64 floating point support in application"
> > > +   default n
> > > +   depends on ARCH_ARM_64
> > > +   help
> > > +           Enable support FPU usage in application
> > Does this config needs to be Arm64 bit? Can't this potentially be
> > re-used for other arch?
> IIUC, Unikraft on x86 kvm plat had supported floating point without any issue
> Do you mean this config should be used for arm32?
Are you suggesting floating is enabled by default in x86 even in the kernel?

Cheers,

--
Julien Grall

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel