Re: [Minios-devel] [UNIKRAFT PATCH 1/3] lib/uksysinfo: Rename internal name to libuksysinfo

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hi Costin,

sometimes it really surprises me how much POSIX is covering. They have 
way too much stuff ;-). But, yes, you are right, it makes sense what you 
are saying. I will do a posix-* renaming with a v2.
Thanks,

Simon

On 14.12.19 15:56, Costin Lupu wrote:
> Hi Simon,
>
> This is only a suggestion, but given that you're renaming uksysinfo,
> maybe you can rename it to posix-sysinfo, because that's just what it
> does, namely providing posix compatibility. And it would be inline with
> the other posix-* libs.
>
> Costin
>
> On 12/12/19 5:09 PM, Simon Kuenzer wrote:
> > Registers the library with `libuksysinfo` to the build. The
> > previous name `uksysinfo` did not follow our naming convention.
> >
> > Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> > ---
> >   lib/uksysinfo/Config.uk   | 3 ++-
> >   lib/uksysinfo/Makefile.uk | 8 ++++----
> >   2 files changed, 6 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/uksysinfo/Config.uk b/lib/uksysinfo/Config.uk
> > index 03d60739..d0464cfd 100644
> > --- a/lib/uksysinfo/Config.uk
> > +++ b/lib/uksysinfo/Config.uk
> > @@ -1,3 +1,4 @@
> > -menuconfig UKSYSINFO
> > +menuconfig LIBUKSYSINFO
> >         bool "uksysinfo: info about system parameters"
> > +       select NOLIBC if !HAVE_LIBC
> >         default n
> > diff --git a/lib/uksysinfo/Makefile.uk b/lib/uksysinfo/Makefile.uk
> > index 28e99fb5..22ac28e7 100644
> > --- a/lib/uksysinfo/Makefile.uk
> > +++ b/lib/uksysinfo/Makefile.uk
> > @@ -1,6 +1,6 @@
> > -$(eval $(call addlib_s,uksysinfo,$(CONFIG_UKSYSINFO)))
> > +$(eval $(call addlib_s,libuksysinfo,$(CONFIG_LIBUKSYSINFO)))
> >   
> > -CINCLUDES-$(CONFIG_UKSYSINFO)    += -I$(UKSYSINFO_BASE)/include
> > -CXXINCLUDES-$(CONFIG_UKSYSINFO)  += -I$(UKSYSINFO_BASE)/include
> > +CINCLUDES-$(CONFIG_LIBUKSYSINFO)    += -I$(LIBUKSYSINFO_BASE)/include
> > +CXXINCLUDES-$(CONFIG_LIBUKSYSINFO)  += -I$(LIBUKSYSINFO_BASE)/include
> >   
> > -UKSYSINFO_SRCS-$(CONFIG_UKSYSINFO) += $(UKSYSINFO_BASE)/sysinfo.c
> > +LIBUKSYSINFO_SRCS-$(CONFIG_LIBUKSYSINFO) += $(LIBUKSYSINFO_BASE)/sysinfo.c
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel